Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: runtime/vm/service.h

Issue 2273463002: vm-service: Reduce copying involved in sending binary events (e.g., heap snapshot). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.h
diff --git a/runtime/vm/service.h b/runtime/vm/service.h
index 420ff6227dcfc04598568e1574674098eeae4e87..6f9d1d60494033f24dbe87359b0b5d097a93b1ba 100644
--- a/runtime/vm/service.h
+++ b/runtime/vm/service.h
@@ -180,16 +180,19 @@ class Service : public AllStatic {
const Array& parameter_values,
const Instance& reply_port,
const Instance& id);
+ // Takes ownership of 'bytes'.
static void SendEvent(const char* stream_id,
const char* event_type,
- const Object& eventMessage);
+ uint8_t* bytes,
+ intptr_t bytes_length);
// Does not take ownership of 'data'.
static void SendEventWithData(const char* stream_id,
const char* event_type,
- const String& meta,
+ const char* metadata,
+ intptr_t metadata_size,
const uint8_t* data,
- intptr_t size);
+ intptr_t data_size);
static void PostEvent(Isolate* isolate,
const char* stream_id,
« no previous file with comments | « no previous file | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698