chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java - Issue 2273373003: [Offline pages] Refactor createClientIdForTabSharing and ClientId/UUID creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Issue 2273373003: [Offline pages] Refactor createClientIdForTabSharing and ClientId/UUID creation (Closed)

Patch Set: Include Guid in name to prevent possible confusion Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

index b36430795a25752004fbbcda18d393d7e846b610..e8e2663f0ae20e009639e8a1902eaede50f7162c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

@@ -360,7 +360,8 @@ public class OfflinePageUtils {

public void onResult(OfflinePageItem item) {

if (item == null) {

// If the page has no offline copy, save the page offline.

- ClientId clientId = ClientId.createClientIdForTabSharing();

+ ClientId clientId = ClientId.createGuidClientIdForNamespace(

+ OfflinePageBridge.SHARE_NAMESPACE);

offlinePageBridge.savePage(webContents, clientId,

savePageCallback(prepareForSharing, offlinePageBridge));

return;