chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java - Issue 2273373003: [Offline pages] Refactor createClientIdForTabSharing and ClientId/UUID creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 2273373003: [Offline pages] Refactor createClientIdForTabSharing and ClientId/UUID creation (Closed)

Patch Set: Include Guid in name to prevent possible confusion Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/ClientId.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

index d169856ddca3e175c0bdde0e0c380931b4d18ca0..25f3139dac75d6cf17842dc5b6233d4b784da6dc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

@@ -18,7 +18,6 @@ import java.util.Collections;

import java.util.HashSet;

import java.util.List;

import java.util.Set;

-import java.util.UUID;

/**

* Access gate to C++ side offline pages functionalities.

@@ -415,9 +414,7 @@ public class OfflinePageBridge {

* @param namespace The namespace for the offline page to be saved later.

public void savePageLaterForDownload(final String url, final String namespace) {

fgorski 2016/08/25 22:50:48 did you consider renamsing this to savePageLaterFo

chili 2016/08/26 17:12:00 Acknowledged. Will do in a different patch.

- // Download UI needs "async_loading" namespace and a random (type 4) GUID.

- String uuid = UUID.randomUUID().toString();

- ClientId clientId = new ClientId(namespace, uuid);

+ ClientId clientId = ClientId.createGuidClientIdForNamespace(namespace);

savePageLater(url, clientId, true /* userRequested */);

}