Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2273243002:
[PCv2] Enable toplevel tracing category (Closed)
|
Created:
4 years, 4 months ago by kouhei (in TOK) Modified:
4 years, 3 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[PCv2] Enable toplevel tracing category
BUG=640222
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/54a95838ec059e34f9f8e8952a1eb484998e5102
Cr-Commit-Position: refs/heads/master@{#414568}
Patch Set 1 #
Total comments: 2
Patch Set 2 : extra space #Messages
Total messages: 32 (17 generated)
Description was changed from ========== [PCv2] Enable toplevel tracing category BUG=640222 ========== to ========== [PCv2] Enable toplevel tracing category BUG=640222 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
kouhei@chromium.org changed reviewers: + nednguyen@google.com, petrcermak@chromium.org
The CQ bit was checked by kouhei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM with one nit. Please wait for Ned's approval (I'm only owner for System Health stuff). Thanks, Petr https://codereview.chromium.org/2273243002/diff/1/tools/perf/benchmarks/page_... File tools/perf/benchmarks/page_cycler_v2.py (right): https://codereview.chromium.org/2273243002/diff/1/tools/perf/benchmarks/page_... tools/perf/benchmarks/page_cycler_v2.py:30: # "navigation" and "blink.user_timing" are needed to capture core nit: remove extra space before "needed".
lgtm
https://codereview.chromium.org/2273243002/diff/1/tools/perf/benchmarks/page_... File tools/perf/benchmarks/page_cycler_v2.py (right): https://codereview.chromium.org/2273243002/diff/1/tools/perf/benchmarks/page_... tools/perf/benchmarks/page_cycler_v2.py:30: # "navigation" and "blink.user_timing" are needed to capture core On 2016/08/25 09:25:42, petrcermak wrote: > nit: remove extra space before "needed". Done.
The CQ bit was checked by kouhei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, petrcermak@chromium.org Link to the patchset: https://codereview.chromium.org/2273243002/#ps20001 (title: "extra space")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/bu...)
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [PCv2] Enable toplevel tracing category BUG=640222 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [PCv2] Enable toplevel tracing category BUG=640222 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/54a95838ec059e34f9f8e8952a1eb484998e5102 Cr-Commit-Position: refs/heads/master@{#414568} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/54a95838ec059e34f9f8e8952a1eb484998e5102 Cr-Commit-Position: refs/heads/master@{#414568} |
