Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: tools/perf/benchmarks/page_cycler_v2.py

Issue 2273243002: [PCv2] Enable toplevel tracing category (Closed)
Patch Set: extra space Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler_v2.py
diff --git a/tools/perf/benchmarks/page_cycler_v2.py b/tools/perf/benchmarks/page_cycler_v2.py
index 8e577427184396adee3628b2d9e2324285405b73..00c40ac40d690eaa319b0a8e5583b0b90483e948 100644
--- a/tools/perf/benchmarks/page_cycler_v2.py
+++ b/tools/perf/benchmarks/page_cycler_v2.py
@@ -21,12 +21,25 @@ class _PageCyclerV2(perf_benchmark.PerfBenchmark):
options = {'pageset_repeat': 2}
def CreateTimelineBasedMeasurementOptions(self):
- cat_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
- filter_string='blink.console,navigation,blink.user_timing,loading')
+ cat_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter()
+
+ # "blink.console" is used for marking ranges in
+ # cache_temperature.MarkTelemetryInternal.
+ cat_filter.AddIncludedCategory('blink.console')
+
+ # "navigation" and "blink.user_timing" are needed to capture core
+ # navigation events.
+ cat_filter.AddIncludedCategory('navigation')
+ cat_filter.AddIncludedCategory('blink.user_timing')
# Below categories are needed for first-meaningful-paint computation.
cat_filter.AddDisabledByDefault('disabled-by-default-blink.debug.layout')
cat_filter.AddIncludedCategory('devtools.timeline')
+ cat_filter.AddIncludedCategory('loading')
+
+ # "toplevel" category is used to capture TaskQueueManager events
+ # necessary to compute time-to-interactive.
+ cat_filter.AddIncludedCategory('toplevel')
tbm_options = timeline_based_measurement.Options(
overhead_level=cat_filter)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698