Issue 2273193003: Remove a redundant frame check in ScreenOrientation::isActiveAndVisible

Issue 2273193003: Remove a redundant frame check in ScreenOrientation::isActiveAndVisible (Closed)

Created:
4 years, 3 months ago by haraken

Modified:
4 years, 3 months ago

Reviewers:
dcheng

CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews, haraken, mlamouri+watch-screen-orientation_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove a redundant frame check in ScreenOrientation::isActiveAndVisible m_client is null after frame gets detached. Hence we don't need to check frame() in ScreenOrientation::isActiveAndVisible. This is a follow-up after https://codereview.chromium.org/2272043003/. BUG= Committed: https://crrev.com/b478d427df2451881e4f94706cd7c9c1a91b2341 Cr-Commit-Position: refs/heads/master@{#414374}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273193003/1

4 years, 3 months ago (2016-08-25 05:10:19 UTC) #5

commit-bot: I haz the power

4 years, 3 months ago (2016-08-25 09:32:40 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b478d427df2451881e4f94706cd7c9c1a91b2341
Cr-Commit-Position: refs/heads/master@{#414374}