third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp - Issue 2273193003: Remove a redundant frame check in ScreenOrientation::isActiveAndVisible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

Issue 2273193003: Remove a redundant frame check in ScreenOrientation::isActiveAndVisible (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

index 150135369a44af01d60d46081065e50b0187ce7b..2e0b532f7e2cd47829b2ed9138557d391e911828 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

@@ -93,7 +93,7 @@ void ScreenOrientationController::updateOrientation()

bool ScreenOrientationController::isActiveAndVisible() const

{

- return m_orientation && m_client && frame() && page() && page()->isPageVisible();

+ return m_orientation && m_client && page() && page()->isPageVisible();

}

void ScreenOrientationController::pageVisibilityChanged()

« no previous file with comments | « no previous file | no next file » | no next file with comments »