scripts/slave/recipe_modules/auto_bisect/bisector.py - Issue 2273173002: Increase timeout for determining initial confidence from 2 hours to 20 hours.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 2273173002: Increase timeout for determining initial confidence from 2 hours to 20 hours. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/auto_bisect/bisector.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py

index 861ebbdc174bef0ecb9c06f02dd3be49413c7f1d..0ce2e38d7cc2ddded802384f52138215c9822b18 100644

--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py

+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py

@@ -46,7 +46,7 @@ DEFAULT_SEARCH_RANGE_PERCENTAGE = 0.25

# How long to re-test the initial good-bad range for until significant

# difference is established.

-REGRESSION_CHECK_TIMEOUT = 2 * 60 * 60

+REGRESSION_CHECK_TIMEOUT = 20 * 60 * 60 # 20 hours. A build times out after 24.

# If we reach this number of samples on the reference range and have not

# achieved statistical significance, bail.

MAX_REQUIRED_SAMPLES = 15

« no previous file with comments | « no previous file | no next file » | no next file with comments »