Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 2273173002: Increase timeout for determining initial confidence from 2 hours to 20 hours. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import json 5 import json
6 import re 6 import re
7 import time 7 import time
8 import urllib 8 import urllib
9 9
10 from . import config_validation 10 from . import config_validation
(...skipping 28 matching lines...) Expand all
39 'LO_FINAL_CONF', # The bisect completed without a culprit. 39 'LO_FINAL_CONF', # The bisect completed without a culprit.
40 ) 40 )
41 41
42 # When we look for the next revision to build, we search nearby revisions 42 # When we look for the next revision to build, we search nearby revisions
43 # looking for a revision that's already been archived. Since we don't want 43 # looking for a revision that's already been archived. Since we don't want
44 # to move *too* far from the original revision, we'll cap the search at 25%. 44 # to move *too* far from the original revision, we'll cap the search at 25%.
45 DEFAULT_SEARCH_RANGE_PERCENTAGE = 0.25 45 DEFAULT_SEARCH_RANGE_PERCENTAGE = 0.25
46 46
47 # How long to re-test the initial good-bad range for until significant 47 # How long to re-test the initial good-bad range for until significant
48 # difference is established. 48 # difference is established.
49 REGRESSION_CHECK_TIMEOUT = 2 * 60 * 60 49 REGRESSION_CHECK_TIMEOUT = 20 * 60 * 60 # 20 hours. A build times out after 24.
50 # If we reach this number of samples on the reference range and have not 50 # If we reach this number of samples on the reference range and have not
51 # achieved statistical significance, bail. 51 # achieved statistical significance, bail.
52 MAX_REQUIRED_SAMPLES = 15 52 MAX_REQUIRED_SAMPLES = 15
53 53
54 # Significance level to use for determining difference between revisions via 54 # Significance level to use for determining difference between revisions via
55 # hypothesis testing. 55 # hypothesis testing.
56 SIGNIFICANCE_LEVEL = 0.01 56 SIGNIFICANCE_LEVEL = 0.01
57 57
58 _FAILED_INITIAL_CONFIDENCE_ABORT_REASON = ( 58 _FAILED_INITIAL_CONFIDENCE_ABORT_REASON = (
59 'The metric values for the initial "good" and "bad" revisions ' 59 'The metric values for the initial "good" and "bad" revisions '
(...skipping 886 matching lines...) Expand 10 before | Expand all | Expand 10 after
946 }) 946 })
947 return revision_rows 947 return revision_rows
948 948
949 def _get_build_url(self): 949 def _get_build_url(self):
950 properties = self.api.m.properties 950 properties = self.api.m.properties
951 bot_url = properties.get('buildbotURL', 951 bot_url = properties.get('buildbotURL',
952 'http://build.chromium.org/p/chromium/') 952 'http://build.chromium.org/p/chromium/')
953 builder_name = urllib.quote(properties.get('buildername', '')) 953 builder_name = urllib.quote(properties.get('buildername', ''))
954 builder_number = str(properties.get('buildnumber', '')) 954 builder_number = str(properties.get('buildnumber', ''))
955 return '%sbuilders/%s/builds/%s' % (bot_url, builder_name, builder_number) 955 return '%sbuilders/%s/builds/%s' % (bot_url, builder_name, builder_number)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698