Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2273133003: Merge "arc: Update notification close button image" (Closed)

Created:
4 years, 3 months ago by xiyuan
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Merge "arc: Update notification close button image" > Update the close button image and fix tapping-not-working issue > since making changes to the file. > > BUG=640399 > BUG=b/30814819 > BUG=b/30917629 > TEST=Manual. Verify new close button image on arc notifications. > And tapping to close works. > > Review-Url: https://codereview.chromium.org/2269143004 > Cr-Commit-Position: refs/heads/master@{#414188} > (cherry picked from commit a9d42b7e1ef639e0a29462046e543561ca37230a) Committed: https://chromium.googlesource.com/chromium/src/+/9e6c9dd34006642d4e52fa9d90be41d11a4c8243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 2 chunks +21 lines, -10 lines 0 comments Download
A ui/resources/default_100_percent/common/arc_notification_close.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/arc_notification_close.png View Binary file 0 comments Download
M ui/resources/ui_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
4 years, 3 months ago (2016-08-25 20:12:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9e6c9dd34006642d4e52fa9d90be41d11a4c8243.

Powered by Google App Engine
This is Rietveld 408576698