arc: Update notification close button image

arc: Update notification close button image

Update the close button image and fix tapping-not-working issue
since making changes to the file.

BUG=640399
BUG=b/30814819
BUG=b/30917629
TEST=Manual. Verify new close button image on arc notifications.
    And tapping to close works.

Committed: https://crrev.com/a9d42b7e1ef639e0a29462046e543561ca37230a
Cr-Commit-Position: refs/heads/master@{#414188}

[xiyuan, 2016-08-23 22:54:49]

xiyuan@chromium.org changed reviewers:
+ oshima@chromium.org, yoshiki@chromium.org

[xiyuan, 2016-08-23 22:54:49]

yoshiki@, please review everything.

oshima@, for owner's review on adding the image and ui_resources.grd change.

[xiyuan, 2016-08-23 22:54:55]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 22:55:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 01:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 01:26:13]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yoshiki, 2016-08-24 09:24:32]

lgtm

https://codereview.chromium.org/2269143004/diff/1/ui/arc/notification/arc_cus...
File ui/arc/notification/arc_custom_notification_view.cc (right):

https://codereview.chromium.org/2269143004/diff/1/ui/arc/notification/arc_cus...
ui/arc/notification/arc_custom_notification_view.cc:131: constexpr int
kTouchExtendedPadding =
nit: could you mention about units in comment? I assume these are "dip".

[oshima, 2016-08-24 13:02:21]

lgtm

[xiyuan, 2016-08-24 15:26:50]

https://codereview.chromium.org/2269143004/diff/1/ui/arc/notification/arc_cus...
File ui/arc/notification/arc_custom_notification_view.cc (right):

https://codereview.chromium.org/2269143004/diff/1/ui/arc/notification/arc_cus...
ui/arc/notification/arc_custom_notification_view.cc:131: constexpr int
kTouchExtendedPadding =
On 2016/08/24 09:24:32, yoshiki wrote:
> nit: could you mention about units in comment? I assume these are "dip".

Done.

[xiyuan, 2016-08-24 15:29:00]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2016-08-24 15:29:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
yoshiki@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2269143004/#ps20001
(title: "comment padding consts are in DIPs and move floating close button test
into EventForwarder")

[commit-bot: I haz the power, 2016-08-24 15:29:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 17:13:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:13:57]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[xiyuan, 2016-08-24 17:17:38]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:18:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 20:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:46:41]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[xiyuan, 2016-08-24 20:52:12]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:53:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 23:07:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-24 23:09:40]

Description was changed from

==========
arc: Update notification close button image

Update the close button image and fix tapping-not-working issue
since making changes to the file.

BUG=640399
BUG=b/30814819
BUG=b/30917629
TEST=Manual. Verify new close button image on arc notifications.
    And tapping to close works.
==========

to

==========
arc: Update notification close button image

Update the close button image and fix tapping-not-working issue
since making changes to the file.

BUG=640399
BUG=b/30814819
BUG=b/30917629
TEST=Manual. Verify new close button image on arc notifications.
    And tapping to close works.

Committed: https://crrev.com/a9d42b7e1ef639e0a29462046e543561ca37230a
Cr-Commit-Position: refs/heads/master@{#414188}
==========

[commit-bot: I haz the power, 2016-08-24 23:09:41]

Patchset 2 (id:??) landed as
https://crrev.com/a9d42b7e1ef639e0a29462046e543561ca37230a
Cr-Commit-Position: refs/heads/master@{#414188}