Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage.html

Issue 2273083002: [MD settings] using h2 for sub-headers consistently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_subpage.html
diff --git a/chrome/browser/resources/settings/settings_page/settings_subpage.html b/chrome/browser/resources/settings/settings_page/settings_subpage.html
index a869431c81d3a2c94f56b8cfe099f143c96f4213..b158856fe47fad8949637da91f3b877bfa2c38e8 100644
--- a/chrome/browser/resources/settings/settings_page/settings_subpage.html
+++ b/chrome/browser/resources/settings/settings_page/settings_subpage.html
@@ -11,11 +11,12 @@
<template>
<style include="settings-shared">
:host {
+ --iron-icon-fill-color: var(--settings-nav-grey);
display: block;
}
.settings-box.first {
- padding-bottom: 16px;
+ min-height: 40px;
padding-top: 8px;
}
@@ -27,9 +28,10 @@
width: 36px;
}
- h2 {
+ h1 {
color: var(--settings-nav-grey);
font-size: 107.6923%; /* go to 14px from 13px */
+ font-weight: 500;
}
settings-subpage-search {
@@ -39,7 +41,7 @@
<div class="settings-box first">
<paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_">
</paper-icon-button>
- <h2>[[pageTitle]]</h2>
+ <h1>[[pageTitle]]</h1>
<template is="dom-if" if="[[searchLabel]]">
<settings-subpage-search label="[[searchLabel]]"
on-search-changed="onSearchChanged_">

Powered by Google App Engine
This is Rietveld 408576698