Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5028)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2273083002: [MD settings] using h2 for sub-headers consistently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.html
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
index 0933f290ad13dabb909d43997aab9d1078efc428..67b1d17220a456a39129a236e007f627fff6a9f8 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
@@ -14,45 +14,49 @@
<link rel="import" type="css" href="chrome://resources/css/action_link.css">
<template>
<style include="settings-shared">
- :host {
- --search-engines-list-item-vertical-space: 8px;
- --search-engines-list-margin: 0 40px;
+ .extension-engines {
+ @apply(--settings-list-frame-padding);
}
- .label {
- margin: 20px;
+
+ settings-omnibox-extension-entry {
+ border-top: var(--settings-separator-line);
}
- .extension-engines {
- margin: var(--search-engines-list-margin);
+
+ settings-omnibox-extension-entry:first-of-type {
+ border-top: none;
}
</style>
- <div>
- <div class="label">$i18n{searchEnginesDefault}</div>
- <settings-search-engines-list engines="[[defaultEngines]]">
- </settings-search-engines-list>
+ <div class="settings-box first">
+ <h2>$i18n{searchEnginesDefault}</h2>
</div>
+ <settings-search-engines-list engines="[[defaultEngines]]">
+ </settings-search-engines-list>
<template is="dom-if" if="[[showAddSearchEngineDialog_]]" restamp>
<settings-search-engine-dialog></settings-search-engine-dialog>
</template>
- <div>
- <div class="label">$i18n{searchEnginesOther}</div>
- <!-- TODO(dbeam): why does on-click work with keyboard but on-tap
- doesn't? -->
- <settings-search-engines-list engines="[[otherEngines]]">
- <a is="action-link" on-tap="onAddSearchEngineTap_" id="addSearchEngine">
- $i18n{searchEnginesAddSearchEngine}</a>
- </settings-search-engines-list>
-
- <template is="dom-if" if="[[showExtensionsList_]]">
- <div class="label">$i18n{searchEnginesExtension}</div>
- <iron-list items="[[extensions]]" class="extension-engines" selectable>
- <template>
- <settings-omnibox-extension-entry engine="[[item]]"
- tabindex$="[[tabIndex]]">
- </settings-omnibox-extension-entry>
- </template>
- </iron-list>
- </template>
+ <div class="settings-box first">
+ <h2>$i18n{searchEnginesOther}</h2>
</div>
+ <!-- TODO(dbeam): why does on-click work with keyboard but on-tap
+ doesn't? -->
+ <settings-search-engines-list engines="[[otherEngines]]">
+ <a class="list-item list-button" is="action-link"
+ on-tap="onAddSearchEngineTap_" id="addSearchEngine">
+ $i18n{searchEnginesAddSearchEngine}</a>
+ </settings-search-engines-list>
+
+ <template is="dom-if" if="[[showExtensionsList_]]">
+ <div class="settings-box first">
+ <h2>$i18n{searchEnginesExtension}</h2>
+ </div>
+ <iron-list items="[[extensions]]" class="extension-engines" selectable>
+ <template>
+ <settings-omnibox-extension-entry engine="[[item]]"
+ tabindex$="[[tabIndex]]">
+ </settings-omnibox-extension-entry>
+ </template>
+ </iron-list>
+ </template>
</template>
<script src="search_engines_page.js"></script>
</dom-module>

Powered by Google App Engine
This is Rietveld 408576698