Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 2273083002: [MD settings] using h2 for sub-headers consistently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
index 90e3a12d1e2ac8a3f839332498593ae3e1626206..7fd219cd7185cb099dc2df88bb8ed35d75624c82 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
@@ -15,10 +15,6 @@
<link rel="import" type="css" href="chrome://resources/css/action_link.css">
<template>
<style include="settings-shared passwords-shared">
- #manageLink {
- margin-bottom: 24px;
- }
-
#password {
background-color: transparent;
border: none;
@@ -61,7 +57,7 @@
sub-label="$i18n{passwordsAutosigninDescription}">
</settings-checkbox>
<div id="manageLink">$i18nRaw{managePasswordsLabel}</div>
- <div class="heading">$i18n{savedPasswordsHeading}</div>
+ <h2>$i18n{savedPasswordsHeading}</h2>
<div class="item-list" scrollable>
<div class="list-item column-header">
<div class="website-column">$i18n{editPasswordWebsiteLabel}</div>
@@ -109,7 +105,7 @@
item="[[activePassword]]">
</password-edit-dialog>
</template>
- <div class="heading">$i18n{passwordExceptionsHeading}</div>
+ <h2>$i18n{passwordExceptionsHeading}</h2>
hcarmona 2016/08/24 23:41:21 Extra space here also.
dschuyler 2016/08/25 02:00:53 Acknowledged.
<div id="passwordExceptionsList"
class="vertical-list list-section item-list">
<template is="dom-repeat" items="[[passwordExceptions]]"

Powered by Google App Engine
This is Rietveld 408576698