Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3498)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2273083002: [MD settings] using h2 for sub-headers consistently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.html
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
index 0933f290ad13dabb909d43997aab9d1078efc428..4b9809bbe879aeb1800085279938f4de60701b20 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
@@ -16,25 +16,23 @@
<style include="settings-shared">
:host {
--search-engines-list-item-vertical-space: 8px;
- --search-engines-list-margin: 0 40px;
- }
- .label {
- margin: 20px;
+ --search-engines-list-margin: 0 36px;
}
+
.extension-engines {
margin: var(--search-engines-list-margin);
}
</style>
- <div>
- <div class="label">$i18n{searchEnginesDefault}</div>
+ <div class="settings-box block">
hcarmona 2016/08/24 23:41:21 This is adding a dividing line between the header
dschuyler 2016/08/25 02:00:53 Ah, I changed this in the next CL, but it should b
+ <h2>$i18n{searchEnginesDefault}</h2>
<settings-search-engines-list engines="[[defaultEngines]]">
</settings-search-engines-list>
</div>
<template is="dom-if" if="[[showAddSearchEngineDialog_]]" restamp>
<settings-search-engine-dialog></settings-search-engine-dialog>
</template>
- <div>
- <div class="label">$i18n{searchEnginesOther}</div>
+ <div class="settings-box block">
hcarmona 2016/08/24 23:41:21 Same here for a dividing line between the lists.
dschuyler 2016/08/25 02:00:53 I think a line makes sense here. I haven't found m
+ <h2>$i18n{searchEnginesOther}</h2>
<!-- TODO(dbeam): why does on-click work with keyboard but on-tap
doesn't? -->
<settings-search-engines-list engines="[[otherEngines]]">
@@ -43,7 +41,7 @@
</settings-search-engines-list>
<template is="dom-if" if="[[showExtensionsList_]]">
- <div class="label">$i18n{searchEnginesExtension}</div>
+ <h2>$i18n{searchEnginesExtension}</h2>
<iron-list items="[[extensions]]" class="extension-engines" selectable>
<template>
<settings-omnibox-extension-entry engine="[[item]]"

Powered by Google App Engine
This is Rietveld 408576698