Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2273003002: [arm] Add support for vminnm and vmaxnm. (Closed)

Created:
4 years, 4 months ago by jbramley
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Add support for vminnm and vmaxnm. These are ARMv8 instructions that will be used in a follow-up patch. BUG= Committed: https://crrev.com/a0ff620fbf399ec6d92e8be2a0efa12f8f4186a7 Cr-Commit-Position: refs/heads/master@{#39193}

Patch Set 1 #

Patch Set 2 : cl format (simulator-arm.cc) #

Patch Set 3 : Rebase and cl format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -0 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 2 1 chunk +63 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 2 1 chunk +164 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
jbramley
4 years, 4 months ago (2016-08-24 10:35:23 UTC) #2
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-24 10:52:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273003002/1
4 years, 4 months ago (2016-08-24 10:53:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22467)
4 years, 4 months ago (2016-08-24 10:57:45 UTC) #7
jbramley
On 2016/08/24 10:57:45, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-24 12:52:22 UTC) #8
epertoso
On 2016/08/24 12:52:22, jbramley wrote: > On 2016/08/24 10:57:45, commit-bot: I haz the power wrote: ...
4 years, 4 months ago (2016-08-24 13:48:11 UTC) #9
jbramley
On 2016/08/24 13:48:11, epertoso wrote: > On 2016/08/24 12:52:22, jbramley wrote: > > On 2016/08/24 ...
4 years, 4 months ago (2016-08-24 13:59:50 UTC) #10
jbramley
> > > Is it no longer possible to override `cl format`? I thought exceptions ...
4 years, 3 months ago (2016-08-30 09:41:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273003002/40001
4 years, 3 months ago (2016-09-06 08:23:27 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-06 08:46:20 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 08:46:39 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a0ff620fbf399ec6d92e8be2a0efa12f8f4186a7
Cr-Commit-Position: refs/heads/master@{#39193}

Powered by Google App Engine
This is Rietveld 408576698