Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2272993003: [Telemetry] Convert long running user stories to the System Health format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: blacklist from smoke test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/data/system_health_desktop.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/system_health_smoke_test.py
diff --git a/tools/perf/benchmarks/system_health_smoke_test.py b/tools/perf/benchmarks/system_health_smoke_test.py
index b4f2e91096005dedf3d27e1eb7ab4aba335d1063..1e795da22c698fa830957f332a73688b79359aff 100644
--- a/tools/perf/benchmarks/system_health_smoke_test.py
+++ b/tools/perf/benchmarks/system_health_smoke_test.py
@@ -48,7 +48,13 @@ _DISABLED_TESTS = frozenset({
'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:media:facebook_photos', # pylint: disable=line-too-long
'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:news:reddit', # pylint: disable=line-too-long
'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:social:facebook', # pylint: disable=line-too-long
- 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.load:news:cnn', # pylint: disable=line-too-long
perezju 2016/08/31 08:25:41 is this re-enabling load:news:cnn by mistake?
petrcermak 2016/08/31 11:31:10 +1
rnephew (Reviews Here) 2016/08/31 15:58:00 Yeah, not on purpose :/
+
+ # Permenently disabled from smoke test for being long-running.
+ 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.long_running:tools:gmail-foreground', # pylint: disable=line-too-long
+ 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.long_running:tools:gmail-background', # pylint: disable=line-too-long
+ 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.long_running:tools:gmail-foreground', # pylint: disable=line-too-long
+ 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.long_running:tools:gmail-background', # pylint: disable=line-too-long
+
petrcermak 2016/08/31 11:31:10 nit: remove blank line
rnephew (Reviews Here) 2016/08/31 15:58:00 Done.
})
« no previous file with comments | « no previous file | tools/perf/page_sets/data/system_health_desktop.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698