[Telemetry] Convert long running user stories to the System Health format.

tools/perf/benchmarks/system_health_smoke_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Run all system health stories used by system health benchmarks.
 
 Only memory benchmarks are used when running these stories to make the total
 cycle time manageable. Other system health benchmarks should be using the same
 stories as memory ones, only with fewer actions (no memory dumping).
 """
@@ skipping 30 matching lines @@
   # crbug.com/641934
   # These tests are taking too long (more than 100s each).
   # TODO(nedn): reenable these test once we have more capacity to run them on
   # CQ.
   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:news:flipboard',  # pylint: disable=line-too-long
   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:media:imgur',  # pylint: disable=line-too-long
   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:media:youtube',  # pylint: disable=line-too-long
   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:media:facebook_photos',  # pylint: disable=line-too-long
   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:news:reddit',  # pylint: disable=line-too-long
   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:social:facebook',  # pylint: disable=line-too-long
-  'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.load:news:cnn',  # pylint: disable=line-too-long

[perezju, 2016/08/31 08:25:41]

is this re-enabling load:news:cnn by mistake?

[petrcermak, 2016/08/31 11:31:10]

+1

[rnephew (Reviews Here), 2016/08/31 15:58:00]

Yeah, not on purpose :/

+
+  # Permenently disabled from smoke test for being long-running.
+  'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.long_running:tools:gmail-foreground',  # pylint: disable=line-too-long
+  'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.long_running:tools:gmail-background',  # pylint: disable=line-too-long
+  'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.long_running:tools:gmail-foreground',  # pylint: disable=line-too-long
+  'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.long_running:tools:gmail-background',  # pylint: disable=line-too-long
+

[petrcermak, 2016/08/31 11:31:10]

nit: remove blank line

[rnephew (Reviews Here), 2016/08/31 15:58:00]

Done.

 })
 
 
 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
 
   # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
   #
   # This smoke test dynamically tests all system health user stories. So
   # disabling it for one failing or flaky benchmark would disable a much
   # wider swath of coverage  than is usally intended. Instead, if a test is
@@ skipping 75 matching lines @@
     # parsed during test time which happens after load_tests are called.
     # Since none of our system health benchmarks creates stories based on
     # command line options, it should be ok to pass options=None to
     # CreateStorySet.
     for story_to_smoke_test in (
         benchmark_class().CreateStorySet(options=None).stories):
       suite.addTest(
           _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
 
   return suite