Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2272883003: [remoting android] Explicitly add 'exported' attribute in the manifest. (Closed)

Created:
4 years, 4 months ago by Lambros
Modified:
4 years, 4 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting android] Explicitly add 'exported' attribute in the manifest. Security review recommends explicitly setting the 'exported' property in the Android manifest. This avoids exposing private items on older versions of Android. According to https://developer.android.com/guide/topics/manifest/activity-element.html#exported this setting defaults to true for Activities with Intent filters, false otherwise. BUG=638032 Committed: https://crrev.com/bac8641dd72681de638926e9f9524f5fdfd75af9 Cr-Commit-Position: refs/heads/master@{#414217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M remoting/android/java/AndroidManifest.xml.jinja2 View 3 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lambros
4 years, 4 months ago (2016-08-24 23:10:35 UTC) #3
joedow
lgtm
4 years, 4 months ago (2016-08-24 23:19:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272883003/20001
4 years, 4 months ago (2016-08-24 23:29:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-25 00:28:12 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 00:31:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bac8641dd72681de638926e9f9524f5fdfd75af9
Cr-Commit-Position: refs/heads/master@{#414217}

Powered by Google App Engine
This is Rietveld 408576698