Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: remoting/android/java/AndroidManifest.xml.jinja2

Issue 2272883003: [remoting android] Explicitly add 'exported' attribute in the manifest. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/android/java/AndroidManifest.xml.jinja2
diff --git a/remoting/android/java/AndroidManifest.xml.jinja2 b/remoting/android/java/AndroidManifest.xml.jinja2
index 976943f65b9eeb9d320fd4a1d0ba6c0fef56f4aa..cc15959c1f581b9b6505e0071317691d8b7cab81 100644
--- a/remoting/android/java/AndroidManifest.xml.jinja2
+++ b/remoting/android/java/AndroidManifest.xml.jinja2
@@ -14,10 +14,12 @@
<meta-data
android:name="com.google.android.gms.version"
android:value="@integer/google_play_services_version"/>
- <activity android:name="org.chromium.chromoting.Chromoting"
- android:configChanges="orientation|screenSize"
- android:theme="@style/BaseTheme.NavigationDrawer"
- android:launchMode="singleTask">
+ <activity
+ android:name="org.chromium.chromoting.Chromoting"
+ android:configChanges="orientation|screenSize"
+ android:exported="true"
+ android:theme="@style/BaseTheme.NavigationDrawer"
+ android:launchMode="singleTask">
<intent-filter>
<action android:name="android.intent.action.MAIN"/>
<category android:name="android.intent.category.LAUNCHER"/>
@@ -26,6 +28,7 @@
<activity
android:name="org.chromium.chromoting.ThirdPartyTokenFetcher$OAuthRedirectActivity"
android:enabled="false"
+ android:exported="true"
android:noHistory="true">
<!-- TODO(kevinp): suppress once crbug.com/501593 is fixed. -->
<!--suppress AppIndexingError -->
@@ -37,12 +40,17 @@
<data android:path="/oauthredirect/"/>
</intent-filter>
</activity>
- <activity android:name="org.chromium.chromoting.Desktop"
- android:windowSoftInputMode="adjustResize"/>
- <activity android:name="org.chromium.chromoting.help.HelpActivity"
- android:configChanges="orientation|screenSize"
- android:uiOptions="splitActionBarWhenNarrow">
- </activity>
- <activity android:name="org.chromium.chromoting.help.CreditsActivity"/>
+ <activity
+ android:name="org.chromium.chromoting.Desktop"
+ android:exported="false"
+ android:windowSoftInputMode="adjustResize"/>
+ <activity
+ android:name="org.chromium.chromoting.help.HelpActivity"
+ android:configChanges="orientation|screenSize"
+ android:exported="false"
+ android:uiOptions="splitActionBarWhenNarrow"/>
+ <activity
+ android:name="org.chromium.chromoting.help.CreditsActivity"
+ android:exported="false"/>
</application>
</manifest>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698