Log a rappor metric for external app ids.

Log a rappor metric for external app ids.

BUG=640734
Committed: https://crrev.com/0c7b4da1db5e4e5808015fa5912eed696c963ade
Cr-Commit-Position: refs/heads/master@{#414318}

[Maria, 2016-08-24 23:12:42]

mariakhomenko@chromium.org changed reviewers:
+ dfalcantara@chromium.org, holte@chromium.org

[gone, 2016-08-24 23:33:50]

lgtm

[Steven Holte, 2016-08-25 01:21:32]

lgtm

https://codereview.chromium.org/2272863004/diff/20001/tools/metrics/rappor/ra...
File tools/metrics/rappor/rappor.xml (right):

https://codereview.chromium.org/2272863004/diff/20001/tools/metrics/rappor/ra...
tools/metrics/rappor/rappor.xml:153: is taken from EXTRA_APPLICATION_ID passed
to Chrome in the intent by the
You'll need to provide a list of candidates in
//google3/googledata/chrome/rappor/

[Maria, 2016-08-25 04:32:20]

On 2016/08/25 01:21:32, Steven Holte wrote:
> lgtm
> 
>
https://codereview.chromium.org/2272863004/diff/20001/tools/metrics/rappor/ra...
> File tools/metrics/rappor/rappor.xml (right):
> 
>
https://codereview.chromium.org/2272863004/diff/20001/tools/metrics/rappor/ra...
> tools/metrics/rappor/rappor.xml:153: is taken from EXTRA_APPLICATION_ID passed
> to Chrome in the intent by the
> You'll need to provide a list of candidates in
> //google3/googledata/chrome/rappor/

Looks like there's already android-package-names.txt there. Does it mean we'll
only get it recorded if the package name is on the whitelist?

[Maria, 2016-08-25 04:34:24]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2016-08-25 04:35:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 05:29:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 05:33:04]

Description was changed from

==========
Log a rappor metric for external app ids.

BUG=640734
==========

to

==========
Log a rappor metric for external app ids.

BUG=640734

Committed: https://crrev.com/0c7b4da1db5e4e5808015fa5912eed696c963ade
Cr-Commit-Position: refs/heads/master@{#414318}
==========

[commit-bot: I haz the power, 2016-08-25 05:33:05]

Patchset 2 (id:??) landed as
https://crrev.com/0c7b4da1db5e4e5808015fa5912eed696c963ade
Cr-Commit-Position: refs/heads/master@{#414318}

[Steven Holte, 2016-08-25 20:13:17]

On 2016/08/25 04:32:20, Maria wrote:
> On 2016/08/25 01:21:32, Steven Holte wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/2272863004/diff/20001/tools/metrics/rappor/ra...
> > File tools/metrics/rappor/rappor.xml (right):
> > 
> >
>
https://codereview.chromium.org/2272863004/diff/20001/tools/metrics/rappor/ra...
> > tools/metrics/rappor/rappor.xml:153: is taken from EXTRA_APPLICATION_ID
passed
> > to Chrome in the intent by the
> > You'll need to provide a list of candidates in
> > //google3/googledata/chrome/rappor/
> 
> Looks like there's already android-package-names.txt there. Does it mean we'll
> only get it recorded if the package name is on the whitelist?

It records either way, but the analysis won't be able to explain the data for
reports of any values which are not in that list.  I'm not sure that list is
comprehensive enough, since I think it was targeted at packages which use custom
tabs.