Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2663)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java

Issue 2272863004: Log a rappor metric for external app ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add rappor.xml Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/rappor/rappor.xml » ('j') | tools/metrics/rappor/rappor.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
index 635d840c6fe9078735c4d0a6d0363ca55ef1f75c..bcb8430a9f46ba026e6e3e6e2ba056d101206aa9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
@@ -307,6 +307,12 @@ public class IntentHandler {
ExternalAppId externalId = determineExternalIntentSource(mPackageName, intent);
RecordHistogram.recordEnumeratedHistogram("MobileIntent.PageLoadDueToExternalApp",
externalId.ordinal(), ExternalAppId.INDEX_BOUNDARY.ordinal());
+ if (externalId == ExternalAppId.OTHER) {
+ String appId = IntentUtils.safeGetStringExtra(intent, Browser.EXTRA_APPLICATION_ID);
+ if (!TextUtils.isEmpty(appId)) {
+ RapporServiceBridge.sampleString("Android.PageLoadDueToExternalApp", appId);
+ }
+ }
}
/**
« no previous file with comments | « no previous file | tools/metrics/rappor/rappor.xml » ('j') | tools/metrics/rappor/rappor.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698