remoting/android/java/res/values/dimens.xml - Issue 2272793003: [Remoting Android] New touch feedback texture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/res/values/dimens.xml

Issue 2272793003: [Remoting Android] New touch feedback texture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reviewer's Feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/android/java/res/values/dimens.xml

diff --git a/remoting/android/java/res/values/dimens.xml b/remoting/android/java/res/values/dimens.xml

index 80f26b08fc582eec0558f5aa5e45d0ea6a761041..5cbc8bbed66fc95ff2e663b882253b7f3ec6711c 100644

--- a/remoting/android/java/res/values/dimens.xml

+++ b/remoting/android/java/res/values/dimens.xml

@@ -5,6 +5,7 @@

- <dimen name="feedback_animation_radius_small">25dp</dimen>

- <dimen name="feedback_animation_radius_large">55dp</dimen>

+ <dimen name="long_trackpad_animation_radius">8dp</dimen>

+ <dimen name="short_touch_animation_radius">25dp</dimen>

+ <dimen name="long_touch_animation_radius">55dp</dimen>

joedow 2016/08/24 19:11:06 I think using tiny/small/large here is totally fin

Yuwei 2016/08/24 20:05:43 Done.

</resources>