third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp ('K') | « third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp ('k') | third_party/WebKit/Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp b/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

index 3cfc2a678ced74a287df5990b9eeceddaf3b762f..f5164a95a1cb8b8a9bc6c14b879d15db926d41cf 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

@@ -35,12 +35,12 @@ void V8IDBObserver::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>&

IDBObserverInit idbObserverInit;

ExceptionState exceptionState(ExceptionState::ConstructionContext, "IDBObserver", info.Holder(), info.GetIsolate());

V8IDBObserverInit::toImpl(info.GetIsolate(), info[1], idbObserverInit, exceptionState);

- if (exceptionState.throwIfNeeded())

+ if (exceptionState.hadException())

return;

IDBObserverCallback* callback = new V8IDBObserverCallback(v8::Local<v8::Function>::Cast(info[0]), wrapper, ScriptState::current(info.GetIsolate()));

IDBObserver* observer = IDBObserver::create(*callback, idbObserverInit);

- if (exceptionState.throwIfNeeded())

+ if (exceptionState.hadException())

return;

DCHECK(observer);

v8SetReturnValue(info, V8DOMWrapper::associateObjectWithWrapper(info.GetIsolate(), observer, &wrapperTypeInfo, wrapper));