third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp ('K') | « third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h ('k') | third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp b/third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp

index 5c60faf0e3f22be64ee765e35a39613195c9ac14..f73312483cbb0c6e11b0d9d48768681e609a2bcb 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp

@@ -129,7 +129,7 @@ void V8DeviceMotionEvent::initDeviceMotionEventMethodCustom(const v8::FunctionCa

double interval = 0;

if (intervalProvided) {

interval = toRestrictedDouble(isolate, info[6], exceptionState);

- if (exceptionState.throwIfNeeded())

+ if (exceptionState.hadException())

return;

}

DeviceMotionData* deviceMotionData = DeviceMotionData::create(acceleration, accelerationIncludingGravity, rotationRate, intervalProvided, interval);