[Remoting Android] Remove Synchronizations on RenderData

[Remoting Android] Remove Synchronizations on RenderData

The new OpenGL renderer doesn't expose the display thread to Java so RenderData
won't be used on a non-UI thread. After the removal of the old renderer, it is
safe to remove all those synchronizations on RenderData.

BUG=640059
Committed: https://crrev.com/ebd382690bf3ea3c8b550c3ce3eaae1d083a3633
Cr-Commit-Position: refs/heads/master@{#413880}

[Yuwei, 2016-08-23 01:22:17]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org, lambroslambrou@chromium.org

[Yuwei, 2016-08-23 01:22:18]

ptal

[joedow, 2016-08-23 17:37:45]

lgtm.  Hooray!

https://codereview.chromium.org/2272483002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/RenderData.java (right):

https://codereview.chromium.org/2272483002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/RenderData.java:11: * This
class stores data that needs to be accessed on the event-processing thread.
I would probably update this a bit more since threading doesn't matter.  We
should consider what this class is responsible for now that it isn't the bridge
between the two threads.  Can you update the comment?

[Yuwei, 2016-08-23 17:57:32]

Thanks!

https://codereview.chromium.org/2272483002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/RenderData.java (right):

https://codereview.chromium.org/2272483002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/RenderData.java:11: * This
class stores data that needs to be accessed on the event-processing thread.
On 2016/08/23 17:37:45, joedow wrote:
> I would probably update this a bit more since threading doesn't matter.  We
> should consider what this class is responsible for now that it isn't the
bridge
> between the two threads.  Can you update the comment?

Maybe something like "This class stores UI position data that will be used when
rendering the remote desktop"?

[Lambros, 2016-08-23 21:54:42]

lgtm

https://codereview.chromium.org/2272483002/diff/40001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
(right):

https://codereview.chromium.org/2272483002/diff/40001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:53: RectF
bounds = new RectF(0, 0, mRenderData.imageWidth, mRenderData.imageHeight);
Unrelated to this CL, but maybe move this line further down where |bounds| is
used?

[Yuwei, 2016-08-23 22:07:55]

Thanks :)

https://codereview.chromium.org/2272483002/diff/40001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
(right):

https://codereview.chromium.org/2272483002/diff/40001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:53: RectF
bounds = new RectF(0, 0, mRenderData.imageWidth, mRenderData.imageHeight);
On 2016/08/23 21:54:42, Lambros wrote:
> Unrelated to this CL, but maybe move this line further down where |bounds| is
> used?

Done.

[Yuwei, 2016-08-23 22:08:00]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2016-08-23 22:08:01]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org,
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/2272483002/#ps60001
(title: "Reviewer's Feedback / Merge ToT")

[commit-bot: I haz the power, 2016-08-23 22:08:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 22:56:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-23 23:00:06]

Description was changed from

==========
[Remoting Android] Remove Synchronizations on RenderData

The new OpenGL renderer doesn't expose the display thread to Java so RenderData
won't be used on a non-UI thread. After the removal of the old renderer, it is
safe to remove all those synchronizations on RenderData.

BUG=640059
==========

to

==========
[Remoting Android] Remove Synchronizations on RenderData

The new OpenGL renderer doesn't expose the display thread to Java so RenderData
won't be used on a non-UI thread. After the removal of the old renderer, it is
safe to remove all those synchronizations on RenderData.

BUG=640059

Committed: https://crrev.com/ebd382690bf3ea3c8b550c3ce3eaae1d083a3633
Cr-Commit-Position: refs/heads/master@{#413880}
==========

[commit-bot: I haz the power, 2016-08-23 23:00:07]

Patchset 4 (id:??) landed as
https://crrev.com/ebd382690bf3ea3c8b550c3ce3eaae1d083a3633
Cr-Commit-Position: refs/heads/master@{#413880}