Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java

Issue 2272483002: [Remoting Android] Remove Synchronizations on RenderData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's Feedback / Merge ToT Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java b/remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java
index 27364684fc95aa00fd0a873a5a7804c003dd3968..5f6bcaba5c03a1e14b84a571df06ccce40c19cfd 100644
--- a/remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java
+++ b/remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java
@@ -77,9 +77,7 @@ public class SimulatedTouchInputStrategy implements InputStrategyInterface {
scaledDoubleTapSlopInPx *= DOUBLE_TAP_SLOP_SCALE_FACTOR;
mDoubleTapSlopSquareInPx = scaledDoubleTapSlopInPx * scaledDoubleTapSlopInPx;
- synchronized (mRenderData) {
- mRenderData.drawCursor = false;
- }
+ mRenderData.drawCursor = false;
}
@Override
@@ -154,9 +152,7 @@ public class SimulatedTouchInputStrategy implements InputStrategyInterface {
}
private PointF getCursorPosition() {
- synchronized (mRenderData) {
- return mRenderData.getCursorPosition();
- }
+ return mRenderData.getCursorPosition();
}
private boolean isDoubleTap(float currentX, float currentY, long tapInterval) {
@@ -169,10 +165,9 @@ public class SimulatedTouchInputStrategy implements InputStrategyInterface {
//
float[] currentValues = {currentX, currentY};
float[] previousValues = {mLastTapPoint.x, mLastTapPoint.y};
- synchronized (mRenderData) {
- mRenderData.transform.mapPoints(currentValues);
- mRenderData.transform.mapPoints(previousValues);
- }
+
+ mRenderData.transform.mapPoints(currentValues);
+ mRenderData.transform.mapPoints(previousValues);
int deltaX = (int) (currentValues[0] - previousValues[0]);
int deltaY = (int) (currentValues[1] - previousValues[1]);

Powered by Google App Engine
This is Rietveld 408576698