Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 227243002: Revert of Improving the user transition to add special cases for maximized windows and make the transition "m… (Closed)

Created:
6 years, 8 months ago by nhiroki
Modified:
6 years, 8 months ago
CC:
chromium-reviews, kalyank, ben+ash_chromium.org
Visibility:
Public.

Description

Revert of Improving the user transition to add special cases for maximized windows and make the transition "m… (https://codereview.chromium.org/223823004/) Reason for revert: As sadrul@ mentioned on the original review[1], this seems to be breaking PreferencesTest.MultiProfiles test. Please let me revert... [1] https://codereview.chromium.org/223823004 Original issue's description: > Improving the user transition to add special cases for maximized windows and make the transition "more fluid" > > There were user complaints with the old animation which said that the animation looked janky. This was in part because various transitions (e.g. maximized->maximized) were showing the background animating in the middle of the animation which looked like "flashing") and because there are some real causes where the CPU gets 100% hogged and the UI thread has not time processing the animation. > > This is addressing the first part: Improving the animation by removing the "flash" in the middle and instead transitioning the desktop cleanly from one state to another. > > The shelf animation stays the same, but the windows will cross dissolve. When switching from maximize to maximize, the desktop will not shine through and when switching from / or to maximize, the desktop background will only show the desktop background from the user which is not maximized. This way the intermediate frames do not show "some state". > > BUG=357852 > TEST=unittest & visual checking > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261944 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262024 TBR=oshima@chromium.org,skuhne@chromium.org NOTREECHECKS=true NOTRY=true BUG=357852 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -704 lines) Patch
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h View 6 chunks +31 lines, -21 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 8 chunks +199 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 4 chunks +3 lines, -226 lines 0 comments Download
D chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.h View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc View 1 chunk +0 lines, -324 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
nhiroki
6 years, 8 months ago (2014-04-06 09:43:24 UTC) #1
Created Revert of Improving the user transition to add special cases for
maximized windows and make the transition "m…

Powered by Google App Engine
This is Rietveld 408576698