[api] Add interceptor for defineProperty().

[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also trigger the interceptor. This includes Object.freeze(), Object.preventExtensions(), and Object.seal().

As without this patch, the query interceptor triggers on
defineProperty, unless the definer callback
intercepts the request.

As without this patch, the query interceptor triggers on defineProperty, unless the definer callback intercepts the request.

BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Committed: https://crrev.com/7c401bd84cbd71a0dcdce01031875a7b90471ffb
Cr-Original-Commit-Position: refs/heads/master@{#39094}
Cr-Commit-Position: refs/heads/master@{#39122}

[Franzi, 2016-08-25 09:03:02]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 09:03:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 09:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 09:15:44]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Franzi, 2016-08-25 13:11:07]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 13:11:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 13:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 13:19:09]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Franzi, 2016-08-25 14:11:17]

Description was changed from

==========
[api] Add interceptor for defineProperty().

BUG=
==========

to

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls. 

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal(). 

BUG=
==========

[Franzi, 2016-08-25 14:11:17]

franzih@chromium.org changed reviewers:
+ jochen@chromium.org

[Franzi, 2016-08-25 14:11:36]

Hi Jochen, 

Here's the API addition that allows to define an interceptor for
defineProperty(). Can you have a look please. 

Thanks, 

Franzi

[jochen (gone - plz use gerrit), 2016-08-25 14:23:17]

api lgtm

[jochen (gone - plz use gerrit), 2016-08-25 14:23:44]

hum, you probably also want me to review the rest of the code, right? let me do
that...

[jochen (gone - plz use gerrit), 2016-08-26 18:18:46]

(just publishing my drafts)

the higher level feedback is that I think we should only have one
PropertyDescriptor class

https://codereview.chromium.org/2272383002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2272383002/diff/40001/src/objects.cc#newcode1694
src/objects.cc:1694: ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate, receiver,
btw, is it a problem for your usecase that our interceptors are all in sloppy
mode, ie, we'll always box numbers etc?

https://codereview.chromium.org/2272383002/diff/40001/src/objects.cc#newcode1701
src/objects.cc:1701: std::unique_ptr<v8::PropertyDescriptor> propDescriptor(
nit. property_descriptor

https://codereview.chromium.org/2272383002/diff/40001/src/objects.cc#newcode4602
src/objects.cc:4602: return DefinePropertyWithInterceptorInternal(it,
it->GetInterceptor(),
just inline this method, as it's not used from anywhere else

[Franzi, 2016-08-30 14:59:04]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 14:59:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 15:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 15:23:21]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-08-31 07:39:39]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 07:39:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2016-08-31 11:08:24]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 11:08:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 11:42:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 11:42:59]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-08-31 20:17:40]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 20:17:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 20:50:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 20:50:28]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-09-01 06:38:18]

Hi Jochen, 

I rebased onto the simplified property descriptor. Can you have another look
please? 

Thanks, 

Franzi

https://codereview.chromium.org/2272383002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2272383002/diff/40001/src/objects.cc#newcode1694
src/objects.cc:1694: ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate, receiver,
On 2016/08/26 18:18:46, jochen wrote:
> btw, is it a problem for your usecase that our interceptors are all in sloppy
> mode, ie, we'll always box numbers etc?

So far, nobody has complained about it :)

https://codereview.chromium.org/2272383002/diff/40001/src/objects.cc#newcode1701
src/objects.cc:1701: std::unique_ptr<v8::PropertyDescriptor> propDescriptor(
On 2016/08/26 18:18:46, jochen wrote:
> nit. property_descriptor

Done.

https://codereview.chromium.org/2272383002/diff/40001/src/objects.cc#newcode4602
src/objects.cc:4602: return DefinePropertyWithInterceptorInternal(it,
it->GetInterceptor(),
On 2016/08/26 18:18:46, jochen wrote:
> just inline this method, as it's not used from anywhere else

Done.

[jochen (gone - plz use gerrit), 2016-09-01 14:54:37]

lgtm

[Franzi, 2016-09-01 15:16:05]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2016-09-01 15:16:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 15:18:07]

Description was changed from

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls. 

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal(). 

BUG=
==========

to

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls. 

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal(). 

BUG=
==========

[commit-bot: I haz the power, 2016-09-01 15:18:09]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-01 15:18:35]

Description was changed from

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls. 

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal(). 

BUG=
==========

to

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}
==========

[commit-bot: I haz the power, 2016-09-01 15:18:37]

Patchset 9 (id:??) landed as
https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}

[Jakob Kummerow, 2016-09-01 16:03:23]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2303533004/ by jkummerow@chromium.org.

The reason for reverting is: Breaks
cctest/test-api-interceptors/QueryInterceptor on the waterfall.

[Franzi, 2016-09-02 07:58:03]

Description was changed from

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}
==========

to

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

As without this patch, the query interceptor triggers on
defineProperty, unless the definer callback
intercepts the request.


BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}
==========

[Franzi, 2016-09-02 08:00:38]

Patchset #10 (id:180001) has been deleted

[Franzi, 2016-09-02 08:01:32]

Description was changed from

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

As without this patch, the query interceptor triggers on
defineProperty, unless the definer callback
intercepts the request.


BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}
==========

to

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

As without this patch, the query interceptor triggers on
defineProperty, unless the definer callback
intercepts the request.


BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}
==========

[Franzi, 2016-09-02 08:02:48]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 08:02:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2016-09-02 08:04:03]

Description was changed from

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

As without this patch, the query interceptor triggers on
defineProperty, unless the definer callback
intercepts the request.


BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}
==========

to

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

As without this patch, the query interceptor triggers on
defineProperty, unless the definer callback
intercepts the request.
  
As without this patch, the query interceptor triggers on defineProperty, unless
the definer callback intercepts the request.

BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}
==========

[commit-bot: I haz the power, 2016-09-02 08:30:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 08:30:40]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-09-02 09:06:24]

The CQ bit was checked by franzih@chromium.org

[Franzi, 2016-09-02 09:06:24]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2272383002/#ps220001
(title: "Query descriptor triggers on defineProperty().")

[commit-bot: I haz the power, 2016-09-02 09:06:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 09:08:35]

Description was changed from

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

As without this patch, the query interceptor triggers on
defineProperty, unless the definer callback
intercepts the request.
  
As without this patch, the query interceptor triggers on defineProperty, unless
the definer callback intercepts the request.

BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}
==========

to

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

As without this patch, the query interceptor triggers on
defineProperty, unless the definer callback
intercepts the request.
  
As without this patch, the query interceptor triggers on defineProperty, unless
the definer callback intercepts the request.

BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}
==========

[commit-bot: I haz the power, 2016-09-02 09:08:36]

Committed patchset #11 (id:220001)

[commit-bot: I haz the power, 2016-09-02 09:09:14]

Description was changed from

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

As without this patch, the query interceptor triggers on
defineProperty, unless the definer callback
intercepts the request.
  
As without this patch, the query interceptor triggers on defineProperty, unless
the definer callback intercepts the request.

BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Cr-Commit-Position: refs/heads/master@{#39094}
==========

to

==========
[api] Add interceptor for defineProperty().

With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept
Object.defineProperty() calls.

Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also
trigger the interceptor. This includes Object.freeze(),
Object.preventExtensions(), and Object.seal().

As without this patch, the query interceptor triggers on
defineProperty, unless the definer callback
intercepts the request.

As without this patch, the query interceptor triggers on defineProperty, unless
the definer callback intercepts the request.

BUG=

Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
Committed: https://crrev.com/7c401bd84cbd71a0dcdce01031875a7b90471ffb
Cr-Original-Commit-Position: refs/heads/master@{#39094}
Cr-Commit-Position: refs/heads/master@{#39122}
==========

[commit-bot: I haz the power, 2016-09-02 09:09:15]

Patchset 11 (id:??) landed as
https://crrev.com/7c401bd84cbd71a0dcdce01031875a7b90471ffb
Cr-Commit-Position: refs/heads/master@{#39122}