[api] Add interceptor for getOwnPropertyDescriptor().

[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor, but
it returns only value and attributes, not the accessors. This
PropertyDescriptorCallback returns a descriptor similar to Ecma-262 6.2.4.

You can either set a PropertyQueryCallback or a PropertyDescriptorCallback,
but not both. When you set a callback for DefineProperty(), you can set a
PropertyDescriptorCallback but not a PropertyQueryCallback.

BUG=v8:5359
Committed: https://crrev.com/b0a7738a5feb75d23a9707393d102cc34814fbf7
Cr-Commit-Position: refs/heads/master@{#39279}

[Franzi, 2016-09-05 12:30:39]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 12:30:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 13:04:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 13:04:48]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-09-05 17:56:37]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 17:56:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 18:22:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 18:22:53]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-09-05 19:20:14]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 19:20:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 19:45:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 19:45:11]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-09-06 08:28:07]

Description was changed from

==========
[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor,
but it returns attributes, not an accessor. The PropertyDescriptorCallback
returns the descriptor similar to Ecma-262 6.2.4.

One can either define the interceptor for flattened attributes or
for a property descriptor. Not for both. Whenever a PropertyCallback
for DefineProperty() is installed, a PropertyQueryCallback can not
be installed, but only PropertyDescriptorCallback

BUG=
==========

to

==========
[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor,
but it returns only value and attributes, not the accessors. This 
PropertyDescriptorCallback
returns a descriptor similar to Ecma-262 6.2.4.

You can either set a PropertyQueryCallback or a 
PropertyDescriptorCallback, but not both. 
When you set a callback
for DefineProperty(), you can set a PropertyDescriptorCallback
but not a PropertyQueryCallback.

BUG=
==========

[Franzi, 2016-09-06 08:29:10]

Description was changed from

==========
[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor,
but it returns only value and attributes, not the accessors. This 
PropertyDescriptorCallback
returns a descriptor similar to Ecma-262 6.2.4.

You can either set a PropertyQueryCallback or a 
PropertyDescriptorCallback, but not both. 
When you set a callback
for DefineProperty(), you can set a PropertyDescriptorCallback
but not a PropertyQueryCallback.

BUG=
==========

to

==========
[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor,but it
returns only value and attributes, not the accessors. This
PropertyDescriptorCallback returns a descriptor similar to Ecma-262 6.2.4.

You can either set a PropertyQueryCallback or a PropertyDescriptorCallback, but
not both. When you set a callback
for DefineProperty(), you can set a PropertyDescriptorCallback but not a
PropertyQueryCallback.

BUG=
==========

[Franzi, 2016-09-06 08:29:47]

Description was changed from

==========
[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor,but it
returns only value and attributes, not the accessors. This
PropertyDescriptorCallback returns a descriptor similar to Ecma-262 6.2.4.

You can either set a PropertyQueryCallback or a PropertyDescriptorCallback, but
not both. When you set a callback
for DefineProperty(), you can set a PropertyDescriptorCallback but not a
PropertyQueryCallback.

BUG=
==========

to

==========
[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor, but
it returns only value and attributes, not the accessors. This
PropertyDescriptorCallback returns a descriptor similar to Ecma-262 6.2.4.

You can either set a PropertyQueryCallback or a PropertyDescriptorCallback,
but not both. When you set a callback for DefineProperty(), you can set a
PropertyDescriptorCallback but not a PropertyQueryCallback.

BUG=
==========

[Franzi, 2016-09-06 08:44:10]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 08:44:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2016-09-06 10:47:22]

franzih@chromium.org changed reviewers:
+ jochen@chromium.org

[Franzi, 2016-09-06 10:47:22]

Hi Jochen, 

Here's the last API change needed to fix the Node.js contextify issues. This
allows to intercept getOwnPropertyDescriptor() requests without flattening the
descriptor. Please take a look. 

Thanks, 

Franzi

[jochen (gone - plz use gerrit), 2016-09-06 16:02:34]

https://codereview.chromium.org/2311873002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2311873002/diff/80001/src/objects.cc#newcode7360
src/objects.cc:7360: Handle<Object> receiver = it->GetReceiver();
all our API methods are sloppy, i.e., you need to make sure that receiver is
actually a JSReceiver

https://codereview.chromium.org/2311873002/diff/80001/src/objects.cc#newcode7383
src/objects.cc:7383: return Nothing<bool>();
returning Nothing<> usually implies a pending exception. Is that the case here?

[Franzi, 2016-09-06 16:45:37]

https://codereview.chromium.org/2311873002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2311873002/diff/80001/src/objects.cc#newcode7360
src/objects.cc:7360: Handle<Object> receiver = it->GetReceiver();
On 2016/09/06 16:02:34, jochen wrote:
> all our API methods are sloppy, i.e., you need to make sure that receiver is
> actually a JSReceiver

Done. Thanks!

https://codereview.chromium.org/2311873002/diff/80001/src/objects.cc#newcode7383
src/objects.cc:7383: return Nothing<bool>();
On 2016/09/06 16:02:34, jochen wrote:
> returning Nothing<> usually implies a pending exception. Is that the case
here?

From what I understand, that's the case. I added a try_catch.HasCaught check to
a test.

[jochen (gone - plz use gerrit), 2016-09-07 14:22:29]

I wonder whether we should throw an exception or just crash if an interceptor
returns an invalid value?

[jochen (gone - plz use gerrit), 2016-09-07 14:22:45]

please also reference the tracking bug from the cl description

[Franzi, 2016-09-07 17:38:15]

Description was changed from

==========
[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor, but
it returns only value and attributes, not the accessors. This
PropertyDescriptorCallback returns a descriptor similar to Ecma-262 6.2.4.

You can either set a PropertyQueryCallback or a PropertyDescriptorCallback,
but not both. When you set a callback for DefineProperty(), you can set a
PropertyDescriptorCallback but not a PropertyQueryCallback.

BUG=
==========

to

==========
[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor, but
it returns only value and attributes, not the accessors. This
PropertyDescriptorCallback returns a descriptor similar to Ecma-262 6.2.4.

You can either set a PropertyQueryCallback or a PropertyDescriptorCallback,
but not both. When you set a callback for DefineProperty(), you can set a
PropertyDescriptorCallback but not a PropertyQueryCallback.

BUG=v8:5359
==========

[Franzi, 2016-09-07 17:43:17]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 17:43:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 18:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 18:16:38]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-09-07 19:03:47]

On 2016/09/07 at 14:22:45, jochen wrote:
> please also reference the tracking bug from the cl description

I added a tracking issue and we crash if the descriptor is invalid. Please have
another look.

[jochen (gone - plz use gerrit), 2016-09-08 12:46:32]

lgtm

[Franzi, 2016-09-08 12:49:16]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2016-09-08 12:49:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 12:51:43]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-08 12:51:53]

Description was changed from

==========
[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor, but
it returns only value and attributes, not the accessors. This
PropertyDescriptorCallback returns a descriptor similar to Ecma-262 6.2.4.

You can either set a PropertyQueryCallback or a PropertyDescriptorCallback,
but not both. When you set a callback for DefineProperty(), you can set a
PropertyDescriptorCallback but not a PropertyQueryCallback.

BUG=v8:5359
==========

to

==========
[api] Add interceptor for getOwnPropertyDescriptor().

The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor, but
it returns only value and attributes, not the accessors. This
PropertyDescriptorCallback returns a descriptor similar to Ecma-262 6.2.4.

You can either set a PropertyQueryCallback or a PropertyDescriptorCallback,
but not both. When you set a callback for DefineProperty(), you can set a
PropertyDescriptorCallback but not a PropertyQueryCallback.

BUG=v8:5359

Committed: https://crrev.com/b0a7738a5feb75d23a9707393d102cc34814fbf7
Cr-Commit-Position: refs/heads/master@{#39279}
==========

[commit-bot: I haz the power, 2016-09-08 12:51:54]

Patchset 7 (id:??) landed as
https://crrev.com/b0a7738a5feb75d23a9707393d102cc34814fbf7
Cr-Commit-Position: refs/heads/master@{#39279}