Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

Issue 2272313003: binding: Makes ExceptionState STACK_ALLOCATED(). (Closed)
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
index 6007ab6ad3ec1f243e9be76683a48401c6ce9f65..92429d1b31bd0fd02e693b7ec71ed471ed0934d7 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
@@ -31,7 +31,6 @@
#ifndef ExceptionState_h
#define ExceptionState_h
-#include "bindings/core/v8/OnStackObjectChecker.h"
#include "bindings/core/v8/ScopedPersistent.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/V8ThrowException.h"
@@ -48,8 +47,8 @@ class ScriptPromiseResolver;
class ScriptState;
class CORE_EXPORT ExceptionState {
+ STACK_ALLOCATED();
WTF_MAKE_NONCOPYABLE(ExceptionState);
- USING_FAST_MALLOC(ExceptionState);
public:
enum ContextType {
ConstructionContext,
@@ -133,10 +132,6 @@ public:
// Might return nullptr.
v8::Isolate* isolate() const { return m_isolate; }
-#if ENABLE(ASSERT)
- OnStackObjectChecker& getOnStackObjectChecker() { return m_onStackObjectChecker; }
-#endif
-
protected:
ExceptionCode m_code;
ContextType m_context;
@@ -152,9 +147,6 @@ private:
ScopedPersistent<v8::Value> m_exception;
v8::Isolate* m_isolate;
-#if ENABLE(ASSERT)
- OnStackObjectChecker m_onStackObjectChecker;
-#endif
};
// Used if exceptions can/should not be directly thrown.

Powered by Google App Engine
This is Rietveld 408576698