Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

Issue 2272313003: binding: Makes ExceptionState STACK_ALLOCATED(). (Closed)
Patch Set: Synced. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp
diff --git a/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp b/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp
index ef7b9bf7a067c7e6b7f2b27421b9c5825e357a6d..b43c12611bc0621359edd214da33f7ab71afcdb9 100644
--- a/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp
+++ b/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp
@@ -27,16 +27,21 @@ public:
void timingFunctionRoundTrips(const String& string, ExceptionState& exceptionState)
{
+ ASSERT_FALSE(exceptionState.hadException());
RefPtr<TimingFunction> timingFunction = parseTimingFunction(string, exceptionState);
+ EXPECT_FALSE(exceptionState.hadException());
EXPECT_NE(nullptr, timingFunction);
EXPECT_EQ(string, timingFunction->toString());
+ exceptionState.clearException();
}
void timingFunctionThrows(const String& string, ExceptionState& exceptionState)
{
+ ASSERT_FALSE(exceptionState.hadException());
RefPtr<TimingFunction> timingFunction = parseTimingFunction(string, exceptionState);
EXPECT_TRUE(exceptionState.hadException());
EXPECT_EQ(V8TypeError, exceptionState.code());
+ exceptionState.clearException();
}
@@ -55,7 +60,6 @@ protected:
std::unique_ptr<DummyPageHolder> pageHolder;
Persistent<Document> document;
- TrackExceptionState exceptionState;
};
TEST_F(AnimationAnimationInputHelpersTest, ParseKeyframePropertyAttributes)
@@ -81,6 +85,7 @@ TEST_F(AnimationAnimationInputHelpersTest, ParseKeyframePropertyAttributes)
TEST_F(AnimationAnimationInputHelpersTest, ParseAnimationTimingFunction)
{
+ TrackExceptionState exceptionState;
timingFunctionThrows("", exceptionState);
timingFunctionThrows("initial", exceptionState);
timingFunctionThrows("inherit", exceptionState);
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/v8.gypi ('k') | third_party/WebKit/Source/core/animation/AnimationTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698