Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2272293004: Simply use the variable index to put them into the right ScopeInfo slot rather than sorting (Closed)

Created:
4 years, 3 months ago by Toon Verwaest
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simply use the variable index to put them into the right ScopeInfo slot rather than sorting This interleaves setting names and values in the scope info. It's a little messy since globals and locals are interleaved, but afaiu globals is going away. BUG=v8:5209 Committed: https://crrev.com/4c5c0d83e4e2174d7c006c2a5d25215d003b19e8 Cr-Commit-Position: refs/heads/master@{#38925}

Patch Set 1 #

Patch Set 2 : also add info in the right order, interleaved with adding names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -48 lines) Patch
M src/ast/scopeinfo.cc View 1 2 chunks +24 lines, -31 lines 0 comments Download
M src/ast/variables.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ast/variables.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/debug/liveedit.cc View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Toon Verwaest
ptal
4 years, 3 months ago (2016-08-25 18:57:17 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-25 20:43:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272293004/20001
4 years, 3 months ago (2016-08-26 06:42:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 07:07:20 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 07:07:43 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c5c0d83e4e2174d7c006c2a5d25215d003b19e8
Cr-Commit-Position: refs/heads/master@{#38925}

Powered by Google App Engine
This is Rietveld 408576698