src/ast/variables.h - Issue 2272293004: Simply use the variable index to put them into the right ScopeInfo slot rather than sorting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/variables.h

Issue 2272293004: Simply use the variable index to put them into the right ScopeInfo slot rather than sorting (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: also add info in the right order, interleaved with adding names Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast/variables.h

diff --git a/src/ast/variables.h b/src/ast/variables.h

index f1f63b8a14cb8f9bf151dc3e2c7f9db248995486..043c8c38f603aa513d3ffe5a155e248eb1dbeba1 100644

--- a/src/ast/variables.h

+++ b/src/ast/variables.h

@@ -102,8 +102,6 @@ class Variable final : public ZoneObject {

index_ = index;

}

- static int CompareIndex(Variable* const* v, Variable* const* w);

private:

Scope* scope_;

const AstRawString* name_;

« no previous file with comments | « src/ast/scopeinfo.cc ('k') | src/ast/variables.cc » ('j') | no next file with comments »