DevTools: remove devtools_discovery (merged into content).

DevTools: remove devtools_discovery (merged into content).

BUG=627517
R=dgozman@chromium.org
TBR=for android / headless / webview clients

Committed: https://chromium.googlesource.com/chromium/src/+/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628

[pfeldman, 2016-08-25 00:30:28]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-08-25 01:08:11]

https://codereview.chromium.org/2272213003/diff/1/android_webview/browser/aw_...
File android_webview/browser/aw_dev_tools_discovery_provider.h (right):

https://codereview.chromium.org/2272213003/diff/1/android_webview/browser/aw_...
android_webview/browser/aw_dev_tools_discovery_provider.h:19:
~AwDevToolsDiscoveryProvider() override;
Doesn't override anything.

https://codereview.chromium.org/2272213003/diff/1/chrome/browser/android/dev_...
File chrome/browser/android/dev_tools_discovery_provider_android.cc (right):

https://codereview.chromium.org/2272213003/diff/1/chrome/browser/android/dev_...
chrome/browser/android/dev_tools_discovery_provider_android.cc:210: new
DevToolsDiscoveryProviderAndroid();
style: 4 spaces

https://codereview.chromium.org/2272213003/diff/1/chrome/browser/devtools/chr...
File chrome/browser/devtools/chrome_devtools_manager_delegate.cc (right):

https://codereview.chromium.org/2272213003/diff/1/chrome/browser/devtools/chr...
chrome/browser/devtools/chrome_devtools_manager_delegate.cc:149: if
(!params.target_contents)
This is checked 3 lines above.

https://codereview.chromium.org/2272213003/diff/1/chrome/browser/devtools/chr...
chrome/browser/devtools/chrome_devtools_manager_delegate.cc:169: return
content::DevToolsAgentHost::Create(new TabProxyDelegate(
TabProxyDelegate is a private class from another file :)

https://codereview.chromium.org/2272213003/diff/1/chrome/browser/devtools/chr...
File chrome/browser/devtools/chrome_devtools_manager_delegate.h (right):

https://codereview.chromium.org/2272213003/diff/1/chrome/browser/devtools/chr...
chrome/browser/devtools/chrome_devtools_manager_delegate.h:38:
base::DictionaryValue* command_dict);
style: 4 spaces

https://codereview.chromium.org/2272213003/diff/1/content/public/browser/devt...
File content/public/browser/devtools_agent_host.h (right):

https://codereview.chromium.org/2272213003/diff/1/content/public/browser/devt...
content/public/browser/devtools_agent_host.h:104: static void
AddDiscoveryProvider(const DiscoveryCallback& callback);
Add a comment to this one.

https://codereview.chromium.org/2272213003/diff/1/content/shell/browser/shell...
File content/shell/browser/shell_devtools_manager_delegate.h (right):

https://codereview.chromium.org/2272213003/diff/1/content/shell/browser/shell...
content/shell/browser/shell_devtools_manager_delegate.h:26:
ShellDevToolsManagerDelegate(BrowserContext* browser_context);
explicit

https://codereview.chromium.org/2272213003/diff/1/content/shell/browser/shell...
content/shell/browser/shell_devtools_manager_delegate.h:41:
base::DictionaryValue* command_dict);
style: 4 spaces

[pfeldman, 2016-08-25 01:21:23]

All Done.

[pfeldman, 2016-08-26 19:18:00]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-08-26 19:18:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 19:18:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 19:18:41]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[pfeldman, 2016-08-26 19:19:28]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 19:20:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 19:38:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 19:38:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-08-26 20:51:59]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:52:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 20:52:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:52:47]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[pfeldman, 2016-08-26 21:22:43]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 21:23:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-08-26 22:22:50]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 22:23:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:47:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:47:39]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[pfeldman, 2016-08-27 00:40:50]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 00:42:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 00:45:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 00:45:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-08-27 00:49:14]

lgtm

https://codereview.chromium.org/2272213003/diff/100001/chrome/browser/android...
File chrome/browser/android/devtools_manager_delegate_android.cc (left):

https://codereview.chromium.org/2272213003/diff/100001/chrome/browser/android...
chrome/browser/android/devtools_manager_delegate_android.cc:29: namespace {
Bring back the namespace!

https://codereview.chromium.org/2272213003/diff/100001/chrome/browser/android...
File chrome/browser/android/devtools_manager_delegate_android.cc (right):

https://codereview.chromium.org/2272213003/diff/100001/chrome/browser/android...
chrome/browser/android/devtools_manager_delegate_android.cc:1: // Copyright 2014
The Chromium Authors. All rights reserved.
Stray change?

https://codereview.chromium.org/2272213003/diff/100001/chrome/browser/android...
chrome/browser/android/devtools_manager_delegate_android.cc:221: return
DevToolsAgentHost::kTypePage;
Use TabAndroid::FromWebContents(web_contents) here as well.

https://codereview.chromium.org/2272213003/diff/120001/chrome/browser/devtool...
File chrome/browser/devtools/chrome_devtools_manager_delegate.cc (right):

https://codereview.chromium.org/2272213003/diff/120001/chrome/browser/devtool...
chrome/browser/devtools/chrome_devtools_manager_delegate.cc:30:
content::DevToolsAgentHost::AddDiscoveryProvider(
Let's have a default provider if nothing was added.

[pfeldman, 2016-08-27 01:53:55]

https://codereview.chromium.org/2272213003/diff/100001/chrome/browser/android...
File chrome/browser/android/devtools_manager_delegate_android.cc (left):

https://codereview.chromium.org/2272213003/diff/100001/chrome/browser/android...
chrome/browser/android/devtools_manager_delegate_android.cc:29: namespace {
On 2016/08/27 00:49:13, dgozman wrote:
> Bring back the namespace!

Done.

https://codereview.chromium.org/2272213003/diff/100001/chrome/browser/android...
File chrome/browser/android/devtools_manager_delegate_android.cc (right):

https://codereview.chromium.org/2272213003/diff/100001/chrome/browser/android...
chrome/browser/android/devtools_manager_delegate_android.cc:1: // Copyright 2014
The Chromium Authors. All rights reserved.
No, git picked wrong prototype.

https://codereview.chromium.org/2272213003/diff/100001/chrome/browser/android...
chrome/browser/android/devtools_manager_delegate_android.cc:221: return
DevToolsAgentHost::kTypePage;
On 2016/08/27 00:49:13, dgozman wrote:
> Use TabAndroid::FromWebContents(web_contents) here as well.

What?

[pfeldman, 2016-08-27 01:54:00]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 01:54:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 01:58:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:58:17]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-08-27 02:04:27]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-08-27 02:04:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2272213003/#ps180001
(title: "tab shortcut")

[pfeldman, 2016-08-27 02:04:32]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-08-27 02:04:38]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 02:05:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 02:28:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 02:28:49]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[pfeldman, 2016-08-29 17:08:14]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-08-29 17:08:14]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2272213003/#ps200001
(title: "build fix")

[commit-bot: I haz the power, 2016-08-29 17:15:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 18:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 18:00:13]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-08-29 19:38:07]

Description was changed from

==========
DevTools: remove devtools_discovery (merged into content).

BUG=627517
==========

to

==========
DevTools: remove devtools_discovery (merged into content).

BUG=627517
TBR= for android / headless / webview clients
==========

[pfeldman, 2016-08-29 19:38:16]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-08-29 20:13:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 00:09:05]

Description was changed from

==========
DevTools: remove devtools_discovery (merged into content).

BUG=627517
TBR= for android / headless / webview clients
==========

to

==========
DevTools: remove devtools_discovery (merged into content).

BUG=627517
R=dgozman@chromium.org
TBR=for android / headless / webview clients

Committed: https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628
Cr-Commit-Position: refs/heads/master@{#415041}
==========

[commit-bot: I haz the power, 2016-08-30 00:09:06]

Patchset 11 (id:??) landed as
https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628
Cr-Commit-Position: refs/heads/master@{#415041}

[pfeldman, 2016-08-30 00:10:38]

Description was changed from

==========
DevTools: remove devtools_discovery (merged into content).

BUG=627517
R=dgozman@chromium.org
TBR=for android / headless / webview clients

Committed: https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628
Cr-Commit-Position: refs/heads/master@{#415041}
==========

to

==========
DevTools: remove devtools_discovery (merged into content).

BUG=627517
R=dgozman@chromium.org
TBR=for android / headless / webview clients

Committed:
https://chromium.googlesource.com/chromium/src/+/43f56b7c7e3fdbd2567c8c5a5a63...
==========

[pfeldman, 2016-08-30 00:10:40]

Committed patchset #11 (id:200001) manually as
43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628 (presubmit successful).