Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

Issue 2272213003: DevTools: remove devtools_discovery (merged into content). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/devtools/chrome_devtools_manager_delegate.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/chrome_devtools_manager_delegate.h" 5 #include "chrome/browser/devtools/chrome_devtools_manager_delegate.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "chrome/browser/devtools/devtools_network_protocol_handler.h" 9 #include "chrome/browser/devtools/devtools_network_protocol_handler.h"
10 #include "components/devtools_discovery/devtools_discovery_manager.h"
11 #include "content/public/browser/devtools_agent_host.h"
12 #include "content/public/browser/web_contents.h"
13
14 #if !defined(OS_ANDROID)
15 #include "chrome/browser/devtools/devtools_window.h" 10 #include "chrome/browser/devtools/devtools_window.h"
16 #include "chrome/browser/extensions/extension_tab_util.h" 11 #include "chrome/browser/extensions/extension_tab_util.h"
17 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/profiles/profile_manager.h"
14 #include "chrome/browser/ui/browser_navigator.h"
15 #include "chrome/browser/ui/browser_navigator_params.h"
18 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h" 16 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
17 #include "content/public/browser/devtools_agent_host.h"
19 #include "content/public/browser/render_frame_host.h" 18 #include "content/public/browser/render_frame_host.h"
19 #include "content/public/browser/web_contents.h"
20 #include "extensions/browser/extension_host.h" 20 #include "extensions/browser/extension_host.h"
21 #include "extensions/browser/extension_registry.h" 21 #include "extensions/browser/extension_registry.h"
22 #include "extensions/browser/process_manager.h" 22 #include "extensions/browser/process_manager.h"
23 #else // !defined(OS_ANDROID)
24 #include "chrome/browser/android/tab_android.h"
25 #include "chrome/browser/ui/android/tab_model/tab_model.h"
26 #include "chrome/browser/ui/android/tab_model/tab_model_list.h"
27 #endif // !defined(OS_ANDROID)
28
29 using devtools_discovery::DevToolsDiscoveryManager;
30 23
31 char ChromeDevToolsManagerDelegate::kTypeApp[] = "app"; 24 char ChromeDevToolsManagerDelegate::kTypeApp[] = "app";
32 char ChromeDevToolsManagerDelegate::kTypeBackgroundPage[] = "background_page"; 25 char ChromeDevToolsManagerDelegate::kTypeBackgroundPage[] = "background_page";
33 26
27
34 ChromeDevToolsManagerDelegate::ChromeDevToolsManagerDelegate() 28 ChromeDevToolsManagerDelegate::ChromeDevToolsManagerDelegate()
35 : network_protocol_handler_(new DevToolsNetworkProtocolHandler()) { 29 : network_protocol_handler_(new DevToolsNetworkProtocolHandler()) {
30 content::DevToolsAgentHost::AddDiscoveryProvider(
31 base::Bind(&content::DevToolsAgentHost::GetOrCreateAll));
36 } 32 }
37 33
38 ChromeDevToolsManagerDelegate::~ChromeDevToolsManagerDelegate() { 34 ChromeDevToolsManagerDelegate::~ChromeDevToolsManagerDelegate() {
39 } 35 }
40 36
41 void ChromeDevToolsManagerDelegate::Inspect( 37 void ChromeDevToolsManagerDelegate::Inspect(
42 content::DevToolsAgentHost* agent_host) { 38 content::DevToolsAgentHost* agent_host) {
43 #if !defined(OS_ANDROID)
44 Profile* profile = 39 Profile* profile =
45 Profile::FromBrowserContext(agent_host->GetBrowserContext()); 40 Profile::FromBrowserContext(agent_host->GetBrowserContext());
46 if (!profile) 41 if (!profile)
47 return; 42 return;
48 std::string type = agent_host->GetType(); 43 std::string type = agent_host->GetType();
49 if (type == content::DevToolsAgentHost::kTypeSharedWorker || 44 if (type == content::DevToolsAgentHost::kTypeSharedWorker ||
50 type == content::DevToolsAgentHost::kTypeServiceWorker) { 45 type == content::DevToolsAgentHost::kTypeServiceWorker) {
51 DevToolsWindow::OpenDevToolsWindowForWorker(profile, agent_host); 46 DevToolsWindow::OpenDevToolsWindowForWorker(profile, agent_host);
52 return; 47 return;
53 } 48 }
54 content::WebContents* web_contents = agent_host->GetWebContents(); 49 content::WebContents* web_contents = agent_host->GetWebContents();
55 if (web_contents) 50 if (web_contents)
56 DevToolsWindow::OpenDevToolsWindow(web_contents); 51 DevToolsWindow::OpenDevToolsWindow(web_contents);
57 #endif // !defined(OS_ANDROID)
58 } 52 }
59 53
60 base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand( 54 base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand(
61 content::DevToolsAgentHost* agent_host, 55 content::DevToolsAgentHost* agent_host,
62 base::DictionaryValue* command_dict) { 56 base::DictionaryValue* command_dict) {
63 std::unique_ptr<base::DictionaryValue> result =
64 DevToolsDiscoveryManager::GetInstance()->HandleCreateTargetCommand(
65 command_dict);
66 if (result)
67 return result.release(); // Caller takes ownership.
68 return network_protocol_handler_->HandleCommand(agent_host, command_dict); 57 return network_protocol_handler_->HandleCommand(agent_host, command_dict);
69 } 58 }
70 59
71 std::string ChromeDevToolsManagerDelegate::GetTargetType( 60 std::string ChromeDevToolsManagerDelegate::GetTargetType(
72 content::RenderFrameHost* host) { 61 content::RenderFrameHost* host) {
73 content::WebContents* web_contents = 62 content::WebContents* web_contents =
74 content::WebContents::FromRenderFrameHost(host); 63 content::WebContents::FromRenderFrameHost(host);
75 #if !defined(OS_ANDROID)
76 for (TabContentsIterator it; !it.done(); it.Next()) { 64 for (TabContentsIterator it; !it.done(); it.Next()) {
77 if (*it == web_contents) 65 if (*it == web_contents)
78 return content::DevToolsAgentHost::kTypePage; 66 return content::DevToolsAgentHost::kTypePage;
79 } 67 }
80 68
81 if (host->GetParent()) 69 if (host->GetParent())
82 return content::DevToolsAgentHost::kTypeFrame; 70 return content::DevToolsAgentHost::kTypeFrame;
83 71
84 const extensions::Extension* extension = extensions::ExtensionRegistry::Get( 72 const extensions::Extension* extension = extensions::ExtensionRegistry::Get(
85 web_contents->GetBrowserContext())->enabled_extensions().GetByID( 73 web_contents->GetBrowserContext())->enabled_extensions().GetByID(
(...skipping 10 matching lines...) Expand all
96 extensions::ProcessManager::Get(profile) 84 extensions::ProcessManager::Get(profile)
97 ->GetBackgroundHostForExtension(extension->id()); 85 ->GetBackgroundHostForExtension(extension->id());
98 if (extension_host && 86 if (extension_host &&
99 extension_host->host_contents() == web_contents) { 87 extension_host->host_contents() == web_contents) {
100 return kTypeBackgroundPage; 88 return kTypeBackgroundPage;
101 } else if (extension->is_hosted_app() 89 } else if (extension->is_hosted_app()
102 || extension->is_legacy_packaged_app() 90 || extension->is_legacy_packaged_app()
103 || extension->is_platform_app()) { 91 || extension->is_platform_app()) {
104 return kTypeApp; 92 return kTypeApp;
105 } 93 }
106 #else // !defined(OS_ANDROID)
107 for (TabModelList::const_iterator iter = TabModelList::begin();
108 iter != TabModelList::end(); ++iter) {
109 TabModel* model = *iter;
110 for (int i = 0; i < model->GetTabCount(); ++i) {
111 TabAndroid* tab = model->GetTabAt(i);
112 if (tab && web_contents == tab->web_contents())
113 return content::DevToolsAgentHost::kTypePage;
114 }
115 }
116 #endif // !defined(OS_ANDROID)
117 return content::DevToolsAgentHost::kTypeOther; 94 return content::DevToolsAgentHost::kTypeOther;
118 } 95 }
119 96
120 std::string ChromeDevToolsManagerDelegate::GetTargetTitle( 97 std::string ChromeDevToolsManagerDelegate::GetTargetTitle(
121 content::RenderFrameHost* host) { 98 content::RenderFrameHost* host) {
122 #if !defined(OS_ANDROID)
123 content::WebContents* web_contents = 99 content::WebContents* web_contents =
124 content::WebContents::FromRenderFrameHost(host); 100 content::WebContents::FromRenderFrameHost(host);
125 if (host->GetParent()) 101 if (host->GetParent())
126 return host->GetLastCommittedURL().spec(); 102 return host->GetLastCommittedURL().spec();
127 for (TabContentsIterator it; !it.done(); it.Next()) { 103 for (TabContentsIterator it; !it.done(); it.Next()) {
128 if (*it == web_contents) 104 if (*it == web_contents)
129 return base::UTF16ToUTF8(web_contents->GetTitle()); 105 return base::UTF16ToUTF8(web_contents->GetTitle());
130 } 106 }
131 const extensions::Extension* extension = extensions::ExtensionRegistry::Get( 107 const extensions::Extension* extension = extensions::ExtensionRegistry::Get(
132 web_contents->GetBrowserContext())->enabled_extensions().GetByID( 108 web_contents->GetBrowserContext())->enabled_extensions().GetByID(
133 host->GetLastCommittedURL().host()); 109 host->GetLastCommittedURL().host());
134 if (extension) 110 if (extension)
135 return extension->name(); 111 return extension->name();
136 #endif // !defined(OS_ANDROID)
137 return ""; 112 return "";
138 } 113 }
139 114
115 scoped_refptr<content::DevToolsAgentHost>
116 ChromeDevToolsManagerDelegate::CreateNewTarget(const GURL& url) {
117 chrome::NavigateParams params(ProfileManager::GetLastUsedProfile(),
118 url, ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
119 params.disposition = NEW_FOREGROUND_TAB;
120 chrome::Navigate(&params);
121 if (!params.target_contents)
122 return nullptr;
123 return content::DevToolsAgentHost::GetOrCreateFor(params.target_contents);
124 }
125
140 void ChromeDevToolsManagerDelegate::DevToolsAgentStateChanged( 126 void ChromeDevToolsManagerDelegate::DevToolsAgentStateChanged(
141 content::DevToolsAgentHost* agent_host, 127 content::DevToolsAgentHost* agent_host,
142 bool attached) { 128 bool attached) {
143 network_protocol_handler_->DevToolsAgentStateChanged(agent_host, attached); 129 network_protocol_handler_->DevToolsAgentStateChanged(agent_host, attached);
144 } 130 }
OLDNEW
« no previous file with comments | « chrome/browser/devtools/chrome_devtools_manager_delegate.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698