Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2272163002: Delete now deprecated BufferedDataSource and friends. (Closed)

Created:
4 years, 4 months ago by DaleCurtis
Modified:
4 years, 4 months ago
Reviewers:
hubbe
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete now deprecated BufferedDataSource and friends. This was temporarily introduced to A/B test MultibufferDataSource which has been stable since M52 now. Time to delete! BUG=588903 TEST=compile Committed: https://crrev.com/b6e052f5edf72fd147f15bff50523a4d085fc14b Cr-Commit-Position: refs/heads/master@{#414223}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete BufferedResourceLoader too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -4515 lines) Patch
M media/blink/BUILD.gn View 1 2 chunks +0 lines, -6 lines 0 comments Download
M media/blink/active_loader.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/active_loader.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D media/blink/buffered_data_source.h View 1 chunk +0 lines, -348 lines 0 comments Download
D media/blink/buffered_data_source.cc View 1 chunk +0 lines, -634 lines 0 comments Download
M media/blink/buffered_data_source_host_impl.h View 1 chunk +17 lines, -1 line 0 comments Download
D media/blink/buffered_data_source_unittest.cc View 1 chunk +0 lines, -1115 lines 0 comments Download
D media/blink/buffered_resource_loader.h View 1 1 chunk +0 lines, -341 lines 0 comments Download
D media/blink/buffered_resource_loader.cc View 1 1 chunk +0 lines, -834 lines 0 comments Download
D media/blink/buffered_resource_loader_unittest.cc View 1 1 chunk +0 lines, -1172 lines 0 comments Download
M media/blink/multibuffer_data_source.h View 4 chunks +37 lines, -16 lines 0 comments Download
M media/blink/multibuffer_data_source.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 3 chunks +3 lines, -4 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 5 chunks +15 lines, -30 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
DaleCurtis
4 years, 4 months ago (2016-08-24 21:29:11 UTC) #2
hubbe
lgtm https://codereview.chromium.org/2272163002/diff/1/media/blink/BUILD.gn File media/blink/BUILD.gn (left): https://codereview.chromium.org/2272163002/diff/1/media/blink/BUILD.gn#oldcode35 media/blink/BUILD.gn:35: "buffered_resource_loader.cc", I think you can also get rid ...
4 years, 4 months ago (2016-08-24 22:16:03 UTC) #3
DaleCurtis
Thanks for review and congrats on your successful launch :) https://codereview.chromium.org/2272163002/diff/1/media/blink/BUILD.gn File media/blink/BUILD.gn (left): https://codereview.chromium.org/2272163002/diff/1/media/blink/BUILD.gn#oldcode35 ...
4 years, 4 months ago (2016-08-24 22:25:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272163002/20001
4 years, 4 months ago (2016-08-24 22:27:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-25 00:36:14 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 00:38:23 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6e052f5edf72fd147f15bff50523a4d085fc14b
Cr-Commit-Position: refs/heads/master@{#414223}

Powered by Google App Engine
This is Rietveld 408576698