Merge DeclarationScope::temps_ and Scope::ordered_variables_ into Scope::locals_

Merge DeclarationScope::temps_ and Scope::ordered_variables_ into Scope::locals_

BUG=v8:5209
Committed: https://crrev.com/5558a50878f04b1aaf711a91880baef5b9c841cf
Cr-Commit-Position: refs/heads/master@{#38920}

[Toon Verwaest, 2016-08-25 17:11:34]

verwaest@chromium.org changed reviewers:
+ adamk@chromium.org, rmcilroy@chromium.org

[Toon Verwaest, 2016-08-25 17:11:35]

adamk: ptal
rmcilroy: ptal at updated bytecode. I presume it's just because variable
allocation order is different, but it'd be good for you to verify :)

[rmcilroy, 2016-08-25 17:28:07]

> rmcilroy: ptal at updated bytecode. I presume it's just because variable
> allocation order is different, but it'd be good for you to verify :)

yup, just looks like the registers in which locals are allocated has changed due
variable
allocation order. LGTM for bytecode changes.

[adamk, 2016-08-25 17:31:31]

adamk@chromium.org changed reviewers:
+ neis@chromium.org

[adamk, 2016-08-25 17:31:31]

+neis who was editing some of this code today

[adamk, 2016-08-25 17:37:10]

https://codereview.chromium.org/2272083003/diff/20001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2272083003/diff/20001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:771: scope->AddLocal(var);
This means that it's now possible to close over temporaries. Have you audited
the callers of NewTemporary() to make sure they never use a name that author
code could cause a lookup of?

Is there anything left that's special about temporaries besides their lack of a
Declaration?

[adamk, 2016-08-25 17:40:12]

lgtm

https://codereview.chromium.org/2272083003/diff/20001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2272083003/diff/20001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:771: scope->AddLocal(var);
On 2016/08/25 17:37:10, adamk wrote:
> This means that it's now possible to close over temporaries. Have you audited
> the callers of NewTemporary() to make sure they never use a name that author
> code could cause a lookup of?
> 
> Is there anything left that's special about temporaries besides their lack of
a
> Declaration?

Okay, I was confused, these still aren't lookup-able, since they're not in
variables_. I think we need better names for locals_ and variables_.

[Toon Verwaest, 2016-08-25 18:41:16]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-08-25 18:41:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 19:11:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 19:12:08]

Description was changed from

==========
Merge DeclarationScope::temps_ and Scope::ordered_variables_ into Scope::locals_

BUG=v8:5209
==========

to

==========
Merge DeclarationScope::temps_ and Scope::ordered_variables_ into Scope::locals_

BUG=v8:5209

Committed: https://crrev.com/5558a50878f04b1aaf711a91880baef5b9c841cf
Cr-Commit-Position: refs/heads/master@{#38920}
==========

[commit-bot: I haz the power, 2016-08-25 19:12:10]

Patchset 2 (id:??) landed as
https://crrev.com/5558a50878f04b1aaf711a91880baef5b9c841cf
Cr-Commit-Position: refs/heads/master@{#38920}