Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2272083003: Merge DeclarationScope::temps_ and Scope::ordered_variables_ into Scope::locals_ (Closed)

Created:
4 years, 3 months ago by Toon Verwaest
Modified:
4 years, 3 months ago
Reviewers:
neis, adamk, rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Merge DeclarationScope::temps_ and Scope::ordered_variables_ into Scope::locals_ BUG=v8:5209 Committed: https://crrev.com/5558a50878f04b1aaf711a91880baef5b9c841cf Cr-Commit-Position: refs/heads/master@{#38920}

Patch Set 1 #

Patch Set 2 : fixes + add cornercase test + still failing cornercase test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -304 lines) Patch
M src/ast/scopes.h View 1 6 chunks +10 lines, -11 lines 0 comments Download
M src/ast/scopes.cc View 1 14 chunks +50 lines, -68 lines 2 comments Download
M test/cctest/interpreter/bytecode_expectations/DoExpression.golden View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForIn.golden View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 23 chunks +115 lines, -115 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Switch.golden View 12 chunks +100 lines, -100 lines 0 comments Download
A test/mjsunit/harmony/default-parameter-do-expression.js View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Toon Verwaest
adamk: ptal rmcilroy: ptal at updated bytecode. I presume it's just because variable allocation order ...
4 years, 3 months ago (2016-08-25 17:11:35 UTC) #2
rmcilroy
> rmcilroy: ptal at updated bytecode. I presume it's just because variable > allocation order ...
4 years, 3 months ago (2016-08-25 17:28:07 UTC) #3
adamk
+neis who was editing some of this code today
4 years, 3 months ago (2016-08-25 17:31:31 UTC) #5
adamk
https://codereview.chromium.org/2272083003/diff/20001/src/ast/scopes.cc File src/ast/scopes.cc (right): https://codereview.chromium.org/2272083003/diff/20001/src/ast/scopes.cc#newcode771 src/ast/scopes.cc:771: scope->AddLocal(var); This means that it's now possible to close ...
4 years, 3 months ago (2016-08-25 17:37:10 UTC) #6
adamk
lgtm https://codereview.chromium.org/2272083003/diff/20001/src/ast/scopes.cc File src/ast/scopes.cc (right): https://codereview.chromium.org/2272083003/diff/20001/src/ast/scopes.cc#newcode771 src/ast/scopes.cc:771: scope->AddLocal(var); On 2016/08/25 17:37:10, adamk wrote: > This ...
4 years, 3 months ago (2016-08-25 17:40:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272083003/20001
4 years, 3 months ago (2016-08-25 18:41:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 19:11:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 19:12:10 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5558a50878f04b1aaf711a91880baef5b9c841cf
Cr-Commit-Position: refs/heads/master@{#38920}

Powered by Google App Engine
This is Rietveld 408576698