test/cctest/interpreter/bytecode_expectations/ForIn.golden - Issue 2272083003: Merge DeclarationScope::temps_ and Scope::ordered_variables_ into Scope::locals_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/ForIn.golden

Issue 2272083003: Merge DeclarationScope::temps_ and Scope::ordered_variables_ into Scope::locals_ (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fixes + add cornercase test + still failing cornercase test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/ast/scopes.cc ('K') | « test/cctest/interpreter/bytecode_expectations/DoExpression.golden ('k') | test/cctest/interpreter/bytecode_expectations/ForOf.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/ForIn.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/ForIn.golden b/test/cctest/interpreter/bytecode_expectations/ForIn.golden

index b6a8df8636a024a4699cc40e72bf515fbd016154..e1fa2be0b08e3d5fc8be19a9738fce180fc36302 100644

--- a/test/cctest/interpreter/bytecode_expectations/ForIn.golden

+++ b/test/cctest/interpreter/bytecode_expectations/ForIn.golden

@@ -69,7 +69,7 @@ bytecode array length: 44

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 42 S> */ B(LdaConstant), U8(0),

- B(Star), R(1),

+ B(Star), R(0),

/* 68 S> */ B(JumpIfUndefined), U8(37),

B(JumpIfNull), U8(35),

B(ToObject), R(3),

@@ -80,7 +80,7 @@ bytecodes: [

B(JumpIfTrue), U8(22),

B(ForInNext), R(3), R(7), R(4), U8(1),

B(JumpIfUndefined), U8(9),

- B(Star), R(0),

+ B(Star), R(1),

/* 54 E> */ B(StackCheck),

B(Star), R(2),

/* 73 S> */ B(Nop),

@@ -108,7 +108,7 @@ bytecode array length: 55

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 42 S> */ B(LdaZero),

- B(Star), R(1),

+ B(Star), R(0),

/* 59 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(3),

B(JumpIfUndefined), U8(45),

B(JumpIfNull), U8(43),

@@ -120,13 +120,13 @@ bytecodes: [

B(JumpIfTrue), U8(30),

B(ForInNext), R(3), R(7), R(4), U8(2),

B(JumpIfUndefined), U8(17),

- B(Star), R(0),

+ B(Star), R(1),

/* 45 E> */ B(StackCheck),

B(Star), R(2),

- /* 70 S> */ B(Ldar), R(0),

- /* 75 E> */ B(Add), R(1), U8(1),

- B(Mov), R(1), R(8),

- B(Star), R(1),

+ /* 70 S> */ B(Ldar), R(1),

+ /* 75 E> */ B(Add), R(0), U8(1),

+ B(Mov), R(0), R(8),

+ B(Star), R(0),

/* 72 E> */ B(ForInStep), R(7),

B(Star), R(7),

B(Jump), U8(-31),