third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp - Issue 2271883002: Fix paint invalidation and painting for composited-scrolling input elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

Issue 2271883002: Fix paint invalidation and painting for composited-scrolling input elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: none Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

diff --git a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

index eeb48ba73fd87a5e111b4e328fbe7850094067f7..eaa3c64c51778447503ef7f6afef0a014e861eb0 100644

--- a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

+++ b/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

@@ -274,7 +274,7 @@ void ObjectPaintInvalidator::invalidatePaintUsingContainer(const LayoutBoxModelO

setBackingNeedsPaintInvalidationInRect(paintInvalidationContainer, dirtyRect, invalidationReason);

}

-void ObjectPaintInvalidator::invalidatePaintRectangle(const LayoutRect& dirtyRect)

+void ObjectPaintInvalidator::invalidatePaintRectangle(const LayoutRect& dirtyRect, DisplayItemClient* displayItemClient)

{

CHECK(m_object.isRooted());

@@ -288,11 +288,13 @@ void ObjectPaintInvalidator::invalidatePaintRectangle(const LayoutRect& dirtyRec

LayoutRect dirtyRectOnBacking = dirtyRect;

PaintLayer::mapRectToPaintInvalidationBacking(m_object, paintInvalidationContainer, dirtyRectOnBacking);

dirtyRectOnBacking.move(m_object.scrollAdjustmentForPaintInvalidation(paintInvalidationContainer));

invalidatePaintUsingContainer(paintInvalidationContainer, dirtyRectOnBacking, PaintInvalidationRectangle);

slowSetPaintingLayerNeedsRepaint();

- m_object.invalidateDisplayItemClients(PaintInvalidationRectangle);

+ if (displayItemClient)

+ invalidateDisplayItemClient(*displayItemClient, PaintInvalidationRectangle);

+ else

+ m_object.invalidateDisplayItemClients(PaintInvalidationRectangle);

}

void ObjectPaintInvalidator::slowSetPaintingLayerNeedsRepaint()