third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 2271883002: Fix paint invalidation and painting for composited-scrolling input elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2271883002: Fix paint invalidation and painting for composited-scrolling input elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: none Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index 9a11c12539444ff9e77ed2f7389253e964c8bef3..66a8520b628caa6759b05d530c2942dbe6f93334 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -1468,10 +1468,6 @@ void PaintLayerScrollableArea::updateCompositingLayersAfterScroll()

bool PaintLayerScrollableArea::usesCompositedScrolling() const

{

- // Scroll form controls on the main thread so they exhibit correct touch scroll event bubbling

- if (box().isIntrinsicallyScrollable(VerticalScrollbar) || box().isIntrinsicallyScrollable(HorizontalScrollbar))

- return false;

// See https://codereview.chromium.org/176633003/ for the tests that fail without this disabler.

DisableCompositingQueryAsserts disabler;

return layer()->hasCompositedLayerMapping() && layer()->compositedLayerMapping()->scrollingLayer();