Remove --base_url from git cl and upload.py

Remove --base_url from git cl and upload.py

R=tandrii@chromium.org
BUG=638750
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f14eaff8148de420c63c87bd67678bf86837641a

[tandrii(chromium), 2016-08-24 11:22:07]

LGTM % suggestion

https://codereview.chromium.org/2271873003/diff/1/git_cl.py
File git_cl.py (left):

https://codereview.chromium.org/2271873003/diff/1/git_cl.py#oldcode2016
git_cl.py:2016: upload_args.extend(['--base_url', remote_url])
i think remote_url isn't used any more. Can you refactor a bit to avoid
computing it?

[agable, 2016-08-24 16:53:44]

https://codereview.chromium.org/2271873003/diff/1/git_cl.py
File git_cl.py (left):

https://codereview.chromium.org/2271873003/diff/1/git_cl.py#oldcode2016
git_cl.py:2016: upload_args.extend(['--base_url', remote_url])
On 2016/08/24 at 11:22:07, tandrii(chromium) wrote:
> i think remote_url isn't used any more. Can you refactor a bit to avoid
computing it?

Yeah, I tried, and it makes surprising tests fail in surprising ways. I'm going
to leave that for the much larger wholesale SVN removal, which will also deal
directly with those tests.

[agable, 2016-08-24 16:53:47]

The CQ bit was checked by agable@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:53:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 17:00:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:00:28]

Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30d64aa9a3b77a10)

[agable, 2016-08-24 18:09:19]

On 2016/08/24 at 17:00:28, commit-bot wrote:
> Try jobs failed on following builders:
>   Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30d64aa9a3b77a10)

Ugh I hate depot_tools presubmit. A full run passes locally. Trying to fix.

[agable, 2016-08-24 18:56:13]

The CQ bit was checked by agable@chromium.org

[agable, 2016-08-24 18:56:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2271873003/#ps20001
(title: "Patch tests")

[commit-bot: I haz the power, 2016-08-24 18:56:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 19:00:21]

Description was changed from

==========
Remove --base_url from git cl and upload.py

R=tandrii@chromium.org
BUG=638750
==========

to

==========
Remove --base_url from git cl and upload.py

R=tandrii@chromium.org
BUG=638750

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f14eaff8148de4...
==========

[commit-bot: I haz the power, 2016-08-24 19:00:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f14eaff8148de4...