git_cl.py - Issue 2271873003: Remove --base_url from git cl and upload.py - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(14)

My Issues | Starred Open | Closed | All

Unified Diff: git_cl.py

Issue 2271873003: Remove --base_url from git cl and upload.py (Closed)

Patch Set: Patch tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | tests/push-basic.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 7dc9bace601bbf45b7f31bd7d44477e23c48df82..1f62dc055b2ff25693dce38d836403806e641707 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -2013,7 +2013,6 @@ class _RietveldChangelistImpl(_ChangelistCodereviewBase):

remote_url = '%s@%s' % (self.GetRemoteUrl(),

self.GetUpstreamBranch().split('/')[-1])

if remote_url:

- upload_args.extend(['--base_url', remote_url])

remote, remote_branch = self.GetRemoteBranch()

target_ref = GetTargetRef(remote, remote_branch, options.target_branch,

settings.GetPendingRefPrefix())

« no previous file with comments | « no previous file | tests/push-basic.sh » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698