Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2271803002: Flush AST results for source outside of the analysis roots. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Flush AST results for source outside of the analysis roots. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b1153095310c76ddbf8da1fcd17cdf360c0fc526

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 4 chunks +25 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 3 months ago (2016-08-23 19:12:56 UTC) #1
Brian Wilkerson
https://codereview.chromium.org/2271803002/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right): https://codereview.chromium.org/2271803002/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart#newcode402 pkg/analysis_server/lib/src/operation/operation_analysis.dart:402: context.analysisCache.flush((target, result) { This won't work well when we ...
4 years, 3 months ago (2016-08-23 19:56:32 UTC) #2
Brian Wilkerson
After our discussion, lgtm as is
4 years, 3 months ago (2016-08-23 20:03:01 UTC) #3
scheglov
4 years, 3 months ago (2016-08-23 21:53:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1153095310c76ddbf8da1fcd17cdf360c0fc526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698