Flush AST results for source outside of the analysis roots.

pkg/analysis_server/lib/src/operation/operation_analysis.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library operation.analysis;
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/computer/computer_highlights.dart';
 import 'package:analysis_server/src/computer/computer_highlights2.dart';
 import 'package:analysis_server/src/computer/computer_outline.dart';
 import 'package:analysis_server/src/computer/computer_overrides.dart';
+import 'package:analysis_server/src/context_manager.dart';
 import 'package:analysis_server/src/domains/analysis/implemented_dart.dart';
 import 'package:analysis_server/src/domains/analysis/navigation.dart';
 import 'package:analysis_server/src/domains/analysis/occurrences.dart';
 import 'package:analysis_server/src/operation/operation.dart';
 import 'package:analysis_server/src/protocol_server.dart' as protocol;
 import 'package:analysis_server/src/services/dependencies/library_dependencies.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/source.dart';
+import 'package:analyzer/src/task/dart.dart';
 
 /**
  * Runs the given function [f] with the working cache size in [context].
  * Returns the result of [f] invocation.
  */
 runWithWorkingCacheSize(AnalysisContext context, f()) {
   int currentCacheSize = context.analysisOptions.cacheSize;
   if (currentCacheSize < PerformAnalysisOperation.WORKING_CACHE_SIZE) {
     setCacheSize(context, PerformAnalysisOperation.WORKING_CACHE_SIZE);
     try {
@@ skipping 335 matching lines @@
     }
     // prepare results
     AnalysisResult result = context.performAnalysisTask();
     List<ChangeNotice> notices = result.changeNotices;
     // nothing to analyze
     if (notices == null) {
       server.scheduleCacheConsistencyValidation(context);
       setCacheSize(context, IDLE_CACHE_SIZE);
       server.sendContextAnalysisDoneNotifications(
           context, AnalysisDoneReason.COMPLETE);
+      _flushCache(server);
       return;
     }
     // process results
     ServerPerformanceStatistics.notices.makeCurrentWhile(() {
       _sendNotices(server, notices);
       _updateIndex(server, notices);
     });
     // continue analysis
     server.addOperation(new PerformAnalysisOperation(context, true));
   }
 
   /**
+   * Flush some of the [context] cache results, which we probably not
+   * going to use anymore.
+   */
+  void _flushCache(AnalysisServer server) {
+    if (context is InternalAnalysisContext) {
+      InternalAnalysisContext context = this.context;
+      // Flush AST results for source outside of the analysis roots.
+      ContextManager contextManager = server.contextManager;
+      context.analysisCache.flush((target, result) {

[Brian Wilkerson, 2016/08/23 19:56:32]

This won't work well when we start sharing more analysis between contexts. My
hope is that we can take sharing far enough that when a user opens two packages
A and B and has a dependency override for B to reference A directly that we will
share the results of analyzing A.

If we do get to that point, and if we flush from B, then all of the results of
analyzing A will be outside of B and will get flushed. Perhaps we want to limit
the flushing to the context's private partition.

+        Source targetSource = target.source;
+        if (RESOLVED_UNIT_RESULTS.contains(result) &&
+            targetSource != null &&
+            !context.prioritySources.contains(targetSource) &&
+            !contextManager.isInAnalysisRoot(targetSource.fullName)) {
+          return true;
+        }
+        return false;
+      });
+    }
+  }
+
+  /**
    * Send the information in the given list of notices back to the client.
    */
   void _sendNotices(AnalysisServer server, List<ChangeNotice> notices) {
     for (int i = 0; i < notices.length; i++) {
       ChangeNotice notice = notices[i];
       Source source = notice.source;
       String file = source.fullName;
       // Dart
       CompilationUnit parsedDartUnit = notice.parsedDartUnit;
       CompilationUnit resolvedDartUnit = notice.resolvedDartUnit;
@@ skipping 134 matching lines @@
 abstract class _SingleFileOperation extends SourceSensitiveOperation {
   final String file;
 
   _SingleFileOperation(AnalysisContext context, this.file) : super(context);
 
   @override
   bool shouldBeDiscardedOnSourceChange(Source source) {
     return source.fullName == file;
   }
 }