[Offline pages] Making sure that destroying the bridge does not leave notification hanging

[Offline pages] Making sure that destroying the bridge does not leave notification hanging

* Preventing memory leak might invalidate the pointer to the bridge on
  C++ side, which is used to complete save page operation and to update
  the notification to failed or succeeded.
* This patch makes sure that callback is invoked as a static function
  and is independent of weak ptr.

BUG=638395
R=dimich

Committed: https://crrev.com/a286301f5467365276284917019525a663cc0da8
Cr-Commit-Position: refs/heads/master@{#413895}

[fgorski, 2016-08-23 17:56:03]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[fgorski, 2016-08-23 17:56:35]

PTAL

[commit-bot: I haz the power, 2016-08-23 17:57:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 18:48:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 18:48:02]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-08-23 22:09:29]

Description was changed from

==========
[Offline pages] Making sure that destroying the bridge does not leave
notification hanging

* Preventing memory leak might invalidate the pointer to the bridge on
  C++ side, which is used to complete save page operation and to update
  the notification to failed or succeeded.
* This patch makes sure that callback is invoked as a static function
  and is independent of weak ptr.

BUG=638395
R=dimich
==========

to

==========
[Offline pages] Making sure that destroying the bridge does not leave
notification hanging

* Preventing memory leak might invalidate the pointer to the bridge on
  C++ side, which is used to complete save page operation and to update
  the notification to failed or succeeded.
* This patch makes sure that callback is invoked as a static function
  and is independent of weak ptr.

BUG=638395
R=dimich
==========

[fgorski, 2016-08-23 22:09:29]

fgorski@chromium.org changed reviewers:
+ dimich@chromium.org
- dimich@google.com

[Dmitry Titov, 2016-08-23 23:17:28]

lgtm

[fgorski, 2016-08-23 23:17:33]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-08-23 23:18:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 23:24:38]

Description was changed from

==========
[Offline pages] Making sure that destroying the bridge does not leave
notification hanging

* Preventing memory leak might invalidate the pointer to the bridge on
  C++ side, which is used to complete save page operation and to update
  the notification to failed or succeeded.
* This patch makes sure that callback is invoked as a static function
  and is independent of weak ptr.

BUG=638395
R=dimich
==========

to

==========
[Offline pages] Making sure that destroying the bridge does not leave
notification hanging

* Preventing memory leak might invalidate the pointer to the bridge on
  C++ side, which is used to complete save page operation and to update
  the notification to failed or succeeded.
* This patch makes sure that callback is invoked as a static function
  and is independent of weak ptr.

BUG=638395
R=dimich
==========

[commit-bot: I haz the power, 2016-08-23 23:24:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-23 23:26:07]

Description was changed from

==========
[Offline pages] Making sure that destroying the bridge does not leave
notification hanging

* Preventing memory leak might invalidate the pointer to the bridge on
  C++ side, which is used to complete save page operation and to update
  the notification to failed or succeeded.
* This patch makes sure that callback is invoked as a static function
  and is independent of weak ptr.

BUG=638395
R=dimich
==========

to

==========
[Offline pages] Making sure that destroying the bridge does not leave
notification hanging

* Preventing memory leak might invalidate the pointer to the bridge on
  C++ side, which is used to complete save page operation and to update
  the notification to failed or succeeded.
* This patch makes sure that callback is invoked as a static function
  and is independent of weak ptr.

BUG=638395
R=dimich

Committed: https://crrev.com/a286301f5467365276284917019525a663cc0da8
Cr-Commit-Position: refs/heads/master@{#413895}
==========

[commit-bot: I haz the power, 2016-08-23 23:26:07]

Patchset 1 (id:??) landed as
https://crrev.com/a286301f5467365276284917019525a663cc0da8
Cr-Commit-Position: refs/heads/master@{#413895}