Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1842)

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

Issue 2271753002: [Offline pages] Making sure that destroying the bridge does not leave notification hanging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
index 46302b3a8a2d22d48e2c2faa8d7e10d0c22c8ea6..0721adddb3fb38ba801c8dac20400ff3febe1486 100644
--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
@@ -10,7 +10,6 @@
#include "base/android/jni_android.h"
#include "base/android/jni_weak_ref.h"
#include "base/macros.h"
-#include "base/memory/weak_ptr.h"
#include "base/supports_user_data.h"
#include "components/offline_pages/downloads/download_ui_adapter.h"
@@ -70,15 +69,14 @@ class OfflinePageDownloadBridge : public DownloadUIAdapter::Observer {
void ItemDeleted(const std::string& guid) override;
private:
- void SavePageCallback(const DownloadUIItem& item,
- OfflinePageModel::SavePageResult result,
- int64_t offline_id);
+ static void SavePageCallback(const DownloadUIItem& item,
+ OfflinePageModel::SavePageResult result,
+ int64_t offline_id);
JavaObjectWeakGlobalRef weak_java_ref_;
// Not owned.
DownloadUIAdapter* download_ui_adapter_;
- base::WeakPtrFactory<OfflinePageDownloadBridge> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(OfflinePageDownloadBridge);
};
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698