Chromium Code Reviews
DescriptionReland of tracing v2: Introduce TraceBufferWriter (https://codereview.chromium.org/2196663002)
Reason for reland:
fixing undefined behavior of move constructor which failed on windows.
Original issue's description:
> tracing v2: Introduce TraceBufferWriter
>
> TraceBufferWriter is the main building block that allows writing
> events into the trace ring buffer. TBW is responsible of exchanging
> chunks with the ring buffer and carving out events out of them.
> The expected design is 1 TraceBufferWriter per thread (% very special
> cases like worker pools which don't have a message loop).
> The major challenge is represented by the fact that events can spread
> over several chunks. TBW is responsible of owning chunks for the
> all lifetime of the event, and returning them as soon as the event
> is finalized.
> In the next CLs:
> - This code will be properly integrated with the stubs generated by
> the protozero protoc compiler plugin.
> - The actual event.proto will be introduced, and TBW::AddEvent will
> return a more structured object other than just a ProtoZeroMessage.
>
> BUG=608719
> TEST=TraceBufferWriterTest.*
>
> Committed: https://crrev.com/9cc78e4aea540c6eba8655d8557b068bde423152
> Cr-Commit-Position: refs/heads/master@{#410669}
TBR=alph@chromium.org,oysteine@chromium.org,kraynov@chromium.org
BUG=608719
Committed: https://crrev.com/494ffeb22edae2db58c5ff88093442246a64e087
Cr-Commit-Position: refs/heads/master@{#414063}
Patch Set 1 : Original CL #Patch Set 2 : Pure rebase after kraynov changes in crrev.com/2228563002 #Patch Set 3 : Adapt to kraynov changes + nits in https://codereview.chromium.org/2228563002/ #Patch Set 4 : Fix undefined behavior of move ctor that caused revert on Win #Messages
Total messages: 11 (8 generated)
|