Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2271653004: Reland of tracing v2: Introduce TraceBufferWriter (https://codereview.chromium.org/2196663002) (Closed)

Created:
4 years, 4 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of tracing v2: Introduce TraceBufferWriter (https://codereview.chromium.org/2196663002) Reason for reland: fixing undefined behavior of move constructor which failed on windows. Original issue's description: > tracing v2: Introduce TraceBufferWriter > > TraceBufferWriter is the main building block that allows writing > events into the trace ring buffer. TBW is responsible of exchanging > chunks with the ring buffer and carving out events out of them. > The expected design is 1 TraceBufferWriter per thread (% very special > cases like worker pools which don't have a message loop). > The major challenge is represented by the fact that events can spread > over several chunks. TBW is responsible of owning chunks for the > all lifetime of the event, and returning them as soon as the event > is finalized. > In the next CLs: > - This code will be properly integrated with the stubs generated by > the protozero protoc compiler plugin. > - The actual event.proto will be introduced, and TBW::AddEvent will > return a more structured object other than just a ProtoZeroMessage. > > BUG=608719 > TEST=TraceBufferWriterTest.* > > Committed: https://crrev.com/9cc78e4aea540c6eba8655d8557b068bde423152 > Cr-Commit-Position: refs/heads/master@{#410669} TBR=alph@chromium.org,oysteine@chromium.org,kraynov@chromium.org BUG=608719 Committed: https://crrev.com/494ffeb22edae2db58c5ff88093442246a64e087 Cr-Commit-Position: refs/heads/master@{#414063}

Patch Set 1 : Original CL #

Patch Set 2 : Pure rebase after kraynov changes in crrev.com/2228563002 #

Patch Set 3 : Adapt to kraynov changes + nits in https://codereview.chromium.org/2228563002/ #

Patch Set 4 : Fix undefined behavior of move ctor that caused revert on Win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+727 lines, -30 lines) Patch
M components/components_tests.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/tracing.gyp View 2 chunks +17 lines, -0 lines 0 comments Download
M components/tracing/BUILD.gn View 1 3 chunks +14 lines, -0 lines 0 comments Download
M components/tracing/core/proto_utils.h View 1 2 3 chunks +10 lines, -7 lines 0 comments Download
M components/tracing/core/proto_utils_unittest.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M components/tracing/core/proto_zero_message.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/tracing/core/proto_zero_message.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/tracing/core/proto_zero_message_handle.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M components/tracing/core/scattered_stream_writer.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/tracing/core/scattered_stream_writer.cc View 2 chunks +3 lines, -1 line 0 comments Download
A components/tracing/core/trace_buffer_writer.h View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
A components/tracing/core/trace_buffer_writer.cc View 1 2 1 chunk +213 lines, -0 lines 0 comments Download
A components/tracing/core/trace_buffer_writer_unittest.cc View 1 2 1 chunk +311 lines, -0 lines 0 comments Download
M components/tracing/core/trace_ring_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/tracing/core/trace_ring_buffer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/tracing/core/trace_ring_buffer_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
A components/tracing/proto/events_chunk.proto View 1 chunk +35 lines, -0 lines 0 comments Download
M components/tracing/test/fake_scattered_buffer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271653004/60001
4 years, 4 months ago (2016-08-24 12:33:32 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-24 13:44:53 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 13:46:30 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/494ffeb22edae2db58c5ff88093442246a64e087
Cr-Commit-Position: refs/heads/master@{#414063}

Powered by Google App Engine
This is Rietveld 408576698