components/tracing/core/proto_zero_message.cc - Issue 2271653004: Reland of tracing v2: Introduce TraceBufferWriter (https://codereview.chromium.org/2196663002)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/core/proto_zero_message.cc

Issue 2271653004: Reland of tracing v2: Introduce TraceBufferWriter (https://codereview.chromium.org/2196663002) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix undefined behavior of move ctor that caused revert on Win Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/tracing/core/proto_zero_message.cc

diff --git a/components/tracing/core/proto_zero_message.cc b/components/tracing/core/proto_zero_message.cc

index a4e056eee259e3e8638af55e81677daf9c0fd3fc..a555683428cacbfc3b0a2cd007fdf3b5f89037c6 100644

--- a/components/tracing/core/proto_zero_message.cc

+++ b/components/tracing/core/proto_zero_message.cc

@@ -82,7 +82,7 @@ size_t ProtoZeroMessage::Finalize() {

#endif

DCHECK_LT(size_, proto::kMaxMessageLength);

DCHECK_EQ(proto::kMessageLengthFieldSize, size_field_.size());

- proto::WriteRedundantLength(

+ proto::WriteRedundantVarInt(

static_cast<uint32_t>(size_ - size_already_written_),

size_field_.begin);

size_field_.reset();

« no previous file with comments | « components/tracing/core/proto_zero_message.h ('k') | components/tracing/core/proto_zero_message_handle.cc » ('j') | no next file with comments »