Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 227163008: Change exception type to Object. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Change exception type to Object. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -37 lines) Patch
M src/isolate.h View 7 chunks +17 lines, -11 lines 0 comments Download
M src/isolate.cc View 4 chunks +4 lines, -17 lines 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Exceptions can no longer be a failure. This change is to reflect that.
6 years, 8 months ago (2014-04-07 12:48:14 UTC) #1
ulan
lgtm
6 years, 8 months ago (2014-04-08 09:15:27 UTC) #2
Yang
6 years, 8 months ago (2014-04-08 09:44:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698